Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752469AbaDDJX0 (ORCPT ); Fri, 4 Apr 2014 05:23:26 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:62743 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752066AbaDDJXU (ORCPT ); Fri, 4 Apr 2014 05:23:20 -0400 Message-ID: <533E7A05.9060806@linaro.org> Date: Fri, 04 Apr 2014 10:23:17 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Stanimir Varbanov , Herbert Xu , "David S. Miller" CC: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 2/9] crypto: qce: Add register defines References: <1396541886-10966-1-git-send-email-svarbanov@mm-sol.com> <1396541886-10966-3-git-send-email-svarbanov@mm-sol.com> In-Reply-To: <1396541886-10966-3-git-send-email-svarbanov@mm-sol.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Minor nitpicks. On 03/04/14 17:17, Stanimir Varbanov wrote: > +#define REQ_SIZE 17 /* bit 20-17 */ I would have defined macros like this with _SHIFT at the end, something like this: #define REQ_SIZE_SHIFT 17 > +#define REQ_SIZE_MASK (0xf << REQ_SIZE) You could possibly use GENMASK macro for this, its much readable, in *some cases* it could reduce few more lines in header too. #define REQ_SIZE_MASK GENMASK(20, 17) My comments are equally applicable to most macros in this header file. -- srini Linaro Qualcomm Landing Team. Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/