Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752753AbaDDMEI (ORCPT ); Fri, 4 Apr 2014 08:04:08 -0400 Received: from mail-qc0-f180.google.com ([209.85.216.180]:63949 "EHLO mail-qc0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbaDDMED (ORCPT ); Fri, 4 Apr 2014 08:04:03 -0400 Date: Fri, 4 Apr 2014 08:03:59 -0400 From: Tejun Heo To: Linus Torvalds Cc: "Eric W. Biederman" , David Miller , Linux Kernel Mailing List , Li Zefan , Linux Containers , cgroups@vger.kernel.org Subject: Re: [GIT PULL] cgroup changes for v3.15-rc1 Message-ID: <20140404120359.GA5461@mtj.dyndns.org> References: <20140403164911.GE24119@htj.dyndns.org> <20140403194335.GC2472@mtj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 03, 2014 at 01:02:45PM -0700, Linus Torvalds wrote: > > The cgroup_root should be destroyed but it isn't, I think. We'd need > > to bump cgroup_root's refcnt only when a new sb is created. It's > > kinda ugly. Hmmm... > > Ok, so I guess we can use that "new_sb_created" thing, and I'll redo > my merge resolution to reflect that. I do find this incredibly ugly. I apparently missed the issue and designed the interface without considering this ugliness. Maybe kernfs could be made to wrap rather than providing mount/kill_sb() functions and hide details about sb or we can simply add fstype->umount() so that there's symmetry; however, the problem is kernfs-specific and other kernfs users would have single static backing store and won't need to care about this, so, for now, I think what it's a ugly but acceptable compromise. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/