Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753527AbaDDPPZ (ORCPT ); Fri, 4 Apr 2014 11:15:25 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:43612 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753150AbaDDPPW (ORCPT ); Fri, 4 Apr 2014 11:15:22 -0400 From: Kevin Hilman To: Viresh Kumar Cc: Thomas Gleixner , =?utf-8?B?RnLDqWTDqXJpYw==?= Weisbecker , Peter Zijlstra , Ingo Molnar , Tejun Heo , Li Zefan , Lists linaro-kernel , Linux Kernel Mailing List , Cgroups Subject: Re: [RFC 2/4] timer: don't migrate pinned timers References: <3fa0ea3a19a51ae2797a25e281763451ad8d2844.1395322529.git.viresh.kumar@linaro.org> <7htxae5plh.fsf@paris.lan> Date: Fri, 04 Apr 2014 08:15:19 -0700 In-Reply-To: (Viresh Kumar's message of "Tue, 1 Apr 2014 10:02:43 +0530") Message-ID: <7h8urlyvlk.fsf@paris.lan> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Viresh Kumar writes: > On 31 March 2014 21:26, Kevin Hilman wrote: >> Viresh Kumar writes: >>> + if (is_pinned) { >>> + pr_warn("%s: can't migrate pinned timer: %p, removing it\n", >>> + __func__, timer); >> >> printk message will be confusing: removing it from what? > > Hmm.. So, I am looking to do two modifications here. Just need inputs > if that would be the right thing to do: > > - do a WARN() here as these timers should have been already removed > - change print to: "can't migrate pinned timer %p, deactivating timer" > > Looks fine? Yes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/