Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752585AbaDELfw (ORCPT ); Sat, 5 Apr 2014 07:35:52 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:48425 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbaDELfb (ORCPT ); Sat, 5 Apr 2014 07:35:31 -0400 MIME-Version: 1.0 In-Reply-To: <533E8E49.1030307@ti.com> References: <1396355974-2257-1-git-send-email-jon@ringle.org> <1396355974-2257-2-git-send-email-jon@ringle.org> <533E8E49.1030307@ti.com> Date: Sat, 5 Apr 2014 13:35:30 +0200 X-Google-Sender-Auth: obasuxOE3uP-TFAB7H0uH01DwU0 Message-ID: Subject: Re: [PATCH v3 2/2] video: da8xx-fb: Fix casting of info->pseudo_palette From: Geert Uytterhoeven To: Tomi Valkeinen Cc: jon@ringle.org, "linux-kernel@vger.kernel.org" , Linux Fbdev development list , Jean-Christophe PLAGNIOL-VILLARD , Jon Ringle , "Etheridge, Darren" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomi, On Fri, Apr 4, 2014 at 12:49 PM, Tomi Valkeinen wrote: > I wonder why the pseudo_palette in fb.h is 'void *' in the first place. > It seems to be cast to 'u32 *' everywhere... Historically, this was driver-specific. Many drivers stored u16 pixel values. I guess it can be changed to u32 now, dropping all casts. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/