Date: Sun, 6 Apr 2014 09:09:03 -0700
From: Josh Triplett <josh@joshtriplett.org>
To: Jonas Hahnfeld <hahnjo@hahnjo.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ana Rey <anarey@gmail.com>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Pablo Neira Ayuso <pablo@gnumonks.org>,
        Rashika Kheria <rashika.kheria@gmail.com>,
        Andreea-Cristina Bernat <bernat.ada@gmail.com>,
        Andrea Merello <andrea.merello@gmail.com>,
        Teodora Baluta <teobaluta@gmail.com>,
        Dan LaManna <dan.lamanna@gmail.com>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8187se: Fix warning symbol should be static
Message-ID: <20140406160903.GA8114@leaf>
References: <1396799183-7412-1-git-send-email-hahnjo@hahnjo.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1396799183-7412-1-git-send-email-hahnjo@hahnjo.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org

On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> This patch solves some sparse warnings about "symbol [...] was not
> declared. Should it be static?" by including the correct header files.
> 
> Signed-off-by: Jonas Hahnfeld <hahnjo@hahnjo.de>

Reviewed-by: Josh Triplett <josh@joshtriplett.org>

> Tested by compile only
> 
>  drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c      | 1 +
>  drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c | 1 +
>  drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c  | 1 +
>  drivers/staging/rtl8187se/r8180_wx.c                       | 1 +
>  4 files changed, 4 insertions(+)
> 
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
> index 101f0c0..03462c3 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
> @@ -19,6 +19,7 @@
>  #include <linux/string.h>
>  #include <linux/errno.h>
>  
> +#include "../r8180.h"
>  #include "ieee80211.h"
>  
>  MODULE_AUTHOR("Jouni Malinen");
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
> index 4fe2538..7eae3d9 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
> @@ -21,6 +21,7 @@
>  #include <linux/string.h>
>  #include <linux/wireless.h>
>  
> +#include "../r8180.h"
>  #include "ieee80211.h"
>  
>  #include <linux/crypto.h>
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
> index f253672..288f86c 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
> @@ -17,6 +17,7 @@
>  #include <linux/skbuff.h>
>  #include <linux/string.h>
>  
> +#include "../r8180.h"
>  #include "ieee80211.h"
>  
>  #include <linux/crypto.h>
> diff --git a/drivers/staging/rtl8187se/r8180_wx.c b/drivers/staging/rtl8187se/r8180_wx.c
> index b552491..57bf01f 100644
> --- a/drivers/staging/rtl8187se/r8180_wx.c
> +++ b/drivers/staging/rtl8187se/r8180_wx.c
> @@ -20,6 +20,7 @@
>  
>  #include "r8180.h"
>  #include "r8180_hw.h"
> +#include "r8180_wx.h"
>  
>  #include <net/iw_handler.h>
>  #include "ieee80211/dot11d.h"
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/