Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754689AbaDGAnB (ORCPT ); Sun, 6 Apr 2014 20:43:01 -0400 Received: from mail-ve0-f178.google.com ([209.85.128.178]:43708 "EHLO mail-ve0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754148AbaDGAmn (ORCPT ); Sun, 6 Apr 2014 20:42:43 -0400 MIME-Version: 1.0 In-Reply-To: <533EBD7D.6090403@monstr.eu> References: <1396563423-30893-1-git-send-email-robherring2@gmail.com> <1396563423-30893-10-git-send-email-robherring2@gmail.com> <533EA2B0.7080703@monstr.eu> <533EB207.1020203@monstr.eu> <533EBD7D.6090403@monstr.eu> Date: Sun, 6 Apr 2014 19:42:43 -0500 Message-ID: Subject: Re: [PATCH 09/20] of/fdt: create common debugfs From: Rob Herring To: Michal Simek Cc: "linux-kernel@vger.kernel.org" , Grant Likely , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 4, 2014 at 9:11 AM, Michal Simek wrote: > On 04/04/2014 03:32 PM, Rob Herring wrote: >> On Fri, Apr 4, 2014 at 8:22 AM, Michal Simek wrote: >>> On 04/04/2014 03:00 PM, Rob Herring wrote: >>>> On Fri, Apr 4, 2014 at 7:16 AM, Michal Simek wrote: >>>>> On 04/04/2014 12:16 AM, Rob Herring wrote: >>>>>> From: Rob Herring >>>>>> >>>>>> Both powerpc and microblaze have the same FDT blob in debugfs feature. >>>>>> Move this to common location and remove the powerpc and microblaze >>>>>> implementations. This feature could become more useful when FDT >>>>>> overlay support is added. >>>> >>>> [snip] >> >>> Anyway I am testing it for microblaze and getting problem >>> caused by this patch: >>> commit 3d2ee8571ac0580d49c3f41fa28336289934900a >>> Author: Rob Herring >>> Date: Wed Apr 2 15:10:14 2014 -0500 >>> >>> of/fdt: Convert FDT functions to use libfdt >>> >>> And reason is that in unflatten_dt_node() >>> >>> pathp = fdt_get_name(blob, *poffset, &l); >>> >>> is returning NULL >>> and here >>> /* version 0x10 has a more compact unit name here instead of the full >>> * path. we accumulate the full path size using "fpsize", we'll rebuild >>> * it later. We detect this because the first character of the name is >>> * not '/'. >>> */ >>> if ((*pathp) != '/') { >>> >>> code is trying to read it which is causing this kernel bug: >>> Oops: kernel access of bad area, sig: 11 >>> >>> It means fdt_next_node(is doing something wrong) >>> >>> Any easy way how to debug it? >> >> I didn't think fdt_get_path should fail. Can you add a print of >> *poffset and pathp values. I think I've fixed this now and updated the branch. Please test again when you have a chance. Thanks, Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/