From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Don Zickus <dzickus@redhat.com>, acme@ghostprotocols.net,
        LKML <linux-kernel@vger.kernel.org>, jmario@redhat.com,
        fowles@inreach.com, bp@alien8.de
Subject: Re: [PATCH 1/4] perf: Allow ability to map cpus to nodes easily
References: <1395689577-214654-1-git-send-email-dzickus@redhat.com>
	<1395689577-214654-2-git-send-email-dzickus@redhat.com>
	<874n2byncs.fsf@sejong.aot.lge.com>
	<20140406121546.GC1164@krava.brq.redhat.com>
Date: Mon, 07 Apr 2014 14:28:35 +0900
In-Reply-To: <20140406121546.GC1164@krava.brq.redhat.com> (Jiri Olsa's message
	of "Sun, 6 Apr 2014 14:15:46 +0200")
Message-ID: <87mwfxyags.fsf@sejong.aot.lge.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org

On Sun, 6 Apr 2014 14:15:46 +0200, Jiri Olsa wrote:
> On Thu, Apr 03, 2014 at 02:48:51PM +0900, Namhyung Kim wrote:
>> More generally, this sysfs access needs to check actual mountpoint using
>> sysfs__mountpoint() IMHO.
>> 
>> Also this API can be generalized like reading int value from a sysfs
>> file as the filename itself represents the content in most cases.
>> 
>> So how about changing this way?  It might reside on somewhere in tools/lib/api/fs/.
>> 
>>   max_cpu_num = sysfs__read_int("devices/system/cpu/possible");
>> 
>>   max_node_num = sysfs__read_int("devices/system/node/possible");
>> 
>> 
>> Hmm.. looking at the code, perf already has filename__read_{int,str} API
>> in util/util.c.  Maybe you can just use it instead.
>
> I think those just read the file, while Don needs to parse
> the map to get max cpu number

Ah, missed that... sorry for noise.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/