Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755077AbaDGKHZ (ORCPT ); Mon, 7 Apr 2014 06:07:25 -0400 Received: from service87.mimecast.com ([91.220.42.44]:36767 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754760AbaDGKHU convert rfc822-to-8bit (ORCPT ); Mon, 7 Apr 2014 06:07:20 -0400 Date: Mon, 7 Apr 2014 11:07:15 +0100 From: Liviu Dudau To: Benjamin Herrenschmidt Cc: Bjorn Helgaas , linux-pci , Catalin Marinas , Will Deacon , linaro-kernel , Arnd Bergmann , LKML , "devicetree@vger.kernel.org" , LAKML , Tanmay Inamdar , Grant Likely Subject: Re: [PATCH v7 4/6] pci: Introduce a domain number for pci_host_bridge. Message-ID: <20140407100715.GI17163@e106497-lin.cambridge.arm.com> Mail-Followup-To: Benjamin Herrenschmidt , Bjorn Helgaas , linux-pci , Catalin Marinas , Will Deacon , linaro-kernel , Arnd Bergmann , LKML , "devicetree@vger.kernel.org" , LAKML , Tanmay Inamdar , Grant Likely References: <1394811272-1547-1-git-send-email-Liviu.Dudau@arm.com> <1394811272-1547-5-git-send-email-Liviu.Dudau@arm.com> <20140405000007.GD15806@google.com> <20140407084623.GG17163@e106497-lin.cambridge.arm.com> <1396862058.3671.40.camel@pasglop> MIME-Version: 1.0 In-Reply-To: <1396862058.3671.40.camel@pasglop> User-Agent: Mutt/1.5.22 (2013-10-16) X-OriginalArrivalTime: 07 Apr 2014 10:07:32.0325 (UTC) FILETIME=[30E22150:01CF5249] X-MC-Unique: 114040711071800101 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 07, 2014 at 10:14:18AM +0100, Benjamin Herrenschmidt wrote: > On Mon, 2014-04-07 at 09:46 +0100, Liviu Dudau wrote: > > > > *My* strategy is to get rid of pci_domain_nr(). I don't see why we need > > to have arch specific way of providing the number, specially after looking > > at the existing implementations that return a value from a variable that > > is never touched or incremented. My guess is that pci_domain_nr() was > > created to work around the fact that there was no domain_nr maintainance in > > the generic code. > > Well, there was no generic host bridge structure. There is one now, it should > go there. Exactly! Hence my patch. After it gets accepted I will go through architectures and remove their version of pci_domain_nr(). Best regards, Liviu > > Cheers, > Ben. > > > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/