Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755417AbaDGR6t (ORCPT ); Mon, 7 Apr 2014 13:58:49 -0400 Received: from mail-ig0-f169.google.com ([209.85.213.169]:43410 "EHLO mail-ig0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754988AbaDGR6q (ORCPT ); Mon, 7 Apr 2014 13:58:46 -0400 MIME-Version: 1.0 In-Reply-To: <5183143.FxBNM0xTAV@wuerfel> References: <1394811272-1547-1-git-send-email-Liviu.Dudau@arm.com> <20140405001953.GE15806@google.com> <20140407083120.GE17163@e106497-lin.cambridge.arm.com> <5183143.FxBNM0xTAV@wuerfel> From: Bjorn Helgaas Date: Mon, 7 Apr 2014 11:58:24 -0600 Message-ID: Subject: Re: [PATCH v7 1/6] pci: Introduce pci_register_io_range() helper function. To: Arnd Bergmann Cc: Liviu Dudau , linux-pci , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , linaro-kernel , LKML , "devicetree@vger.kernel.org" , LAKML , Tanmay Inamdar , Grant Likely Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 7, 2014 at 5:36 AM, Arnd Bergmann wrote: > I think migrating other architectures to use the same code should be > a separate effort from adding a generic implementation that can be > used by arm64. It's probably a good idea to have patches to convert > arm32 and/or microblaze. Let me reiterate that I am 100% in favor of replacing arch-specific code with more generic implementations. However, I am not 100% in favor of doing it as separate efforts (although maybe I could be convinced). The reasons I hesitate are that (1) if only one architecture uses a new "generic" implementation, we really don't know whether it is generic enough, (2) until I see the patches to convert other architectures, I have to assume that I'm the one who will write them, and (3) as soon as we add the code to drivers/pci, it becomes partly my headache to maintain it, even if only one arch benefits from it. Please don't think I'm questioning anyone's intent or good will. It's just that I understand the business pressures, and I know how hard it can be to justify this sort of work to one's management, especially after the immediate problem has been solved. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/