Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756149AbaDHBJ6 (ORCPT ); Mon, 7 Apr 2014 21:09:58 -0400 Received: from mail-ie0-f180.google.com ([209.85.223.180]:42770 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755202AbaDHBJ4 (ORCPT ); Mon, 7 Apr 2014 21:09:56 -0400 MIME-Version: 1.0 In-Reply-To: <37724B2049F71D4C9B086F99DDB2DE112A8F09E3@CMEXMB1.ad.emulex.com> References: <8505576.9F9pTSfgP9@daeseok-laptop.cloud.net> <37724B2049F71D4C9B086F99DDB2DE112A8F09E3@CMEXMB1.ad.emulex.com> Date: Tue, 8 Apr 2014 10:09:55 +0900 Message-ID: Subject: Re: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer From: DaeSeok Youn To: "JBottomley@parallels.com" Cc: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jayamohan Kallickal Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, This patch didn't apply. Please check for me. Thanks. Daeseok Youn 2014-03-12 2:02 GMT+09:00 Jayamohan Kallickal : > > > -----Original Message----- > From: Daeseok Youn [mailto:daeseok.youn@gmail.com] > Sent: Thursday, February 20, 2014 5:13 PM > To: JBottomley@parallels.com > Cc: Jayamohan Kallickal; linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer > > From b483ef302f7d77c586949ae170754d589e8a4935 Mon Sep 17 00:00:00 2001 > From: Daeseok Youn > Date: Fri, 21 Feb 2014 08:39:08 +0900 > Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer > > sparse says: > > drivers/scsi/be2iscsi/be_cmds.c:27:32: warning: > Using plain integer as NULL pointer > drivers/scsi/be2iscsi/be_cmds.c:28:34: warning: > Using plain integer as NULL pointer > drivers/scsi/be2iscsi/be_cmds.c:29:34: warning: > Using plain integer as NULL pointer > > Signed-off-by: Daeseok Youn > --- > drivers/scsi/be2iscsi/be_cmds.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c index 3338391..1ec9793 100644 > --- a/drivers/scsi/be2iscsi/be_cmds.c > +++ b/drivers/scsi/be2iscsi/be_cmds.c > @@ -24,9 +24,9 @@ > int beiscsi_pci_soft_reset(struct beiscsi_hba *phba) { > u32 sreset; > - u8 *pci_reset_offset = 0; > - u8 *pci_online0_offset = 0; > - u8 *pci_online1_offset = 0; > + u8 *pci_reset_offset = NULL; > + u8 *pci_online0_offset = NULL; > + u8 *pci_online1_offset = NULL; > u32 pconline0 = 0; > u32 pconline1 = 0; > u32 i; > -- > 1.7.9.5 > > Acked-By: Jayamohan Kallickal > > -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/