From: Namhyung Kim <namhyung@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Don Zickus <dzickus@redhat.com>, acme@ghostprotocols.net,
        LKML <linux-kernel@vger.kernel.org>, jmario@redhat.com,
        fowles@inreach.com, peterz@infradead.org, eranian@google.com,
        andi.kleen@intel.com
Subject: Re: [PATCH 05/15 V3] perf, c2c: Rework setup code to prepare for features
References: <1395689826-215033-1-git-send-email-dzickus@redhat.com>
	<1395689826-215033-6-git-send-email-dzickus@redhat.com>
	<20140329171018.GA2022@krava.redhat.com>
Date: Tue, 08 Apr 2014 16:41:29 +0900
In-Reply-To: <20140329171018.GA2022@krava.redhat.com> (Jiri Olsa's message of
	"Sat, 29 Mar 2014 18:10:18 +0100")
Message-ID: <87ob0cw9na.fsf@sejong.aot.lge.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org

On Sat, 29 Mar 2014 18:10:18 +0100, Jiri Olsa wrote:
> On Mon, Mar 24, 2014 at 03:36:56PM -0400, Don Zickus wrote:
>
> SNIP
>
>>  
>>  static int perf_c2c__process_load_store(struct perf_c2c *c2c,
>> +					struct addr_location *al,
>>  					struct perf_sample *sample,
>> -					struct addr_location *al)
>> +					struct perf_evsel *evsel)
>>  {
>> -	if (c2c->raw_records)
>> -		perf_sample__fprintf(sample, ' ', "raw input", al, stdout);
>> +	struct mem_info *mi;
>> +
>> +	mi = sample__resolve_mem(sample, al);
>> +	if (!mi)
>> +		return -ENOMEM;
>
> perhaps not directly related to this patchset, but I needed
> attached patch to get resolved data in .bss (static), which
> for some reason happened to be located in executable segment

Wasn't it a read-only/const data?

Hmm.. maybe we could copy the text map and add it to a variable map
group if it has any variables in it..

Thanks,
Namhyung

>
> I wonder why we need this VARIABLE/FUNCTION separation at all,
> I think Arnaldo told me some archs could have same addresses
> for data and functions.. will check ;-)
>
> jirka
>
> ---
> diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
> index d9d86c6..be6d7cf 100644
> --- a/tools/perf/util/machine.c
> +++ b/tools/perf/util/machine.c
> @@ -1220,6 +1220,10 @@ static void ip__resolve_data(struct machine *machine, struct thread *thread,
>  
>  	thread__find_addr_location(thread, machine, m, MAP__VARIABLE, addr,
>  				   &al);
> +	if (!al.map)
> +		thread__find_addr_location(thread, machine, m, MAP__FUNCTION, addr,
> +					   &al);
> +
>  	ams->addr = addr;
>  	ams->al_addr = al.addr;
>  	ams->sym = al.sym;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/