From: Namhyung Kim <namhyung@gmail.com>
To: Don Zickus <dzickus@redhat.com>
Cc: acme@ghostprotocols.net, LKML <linux-kernel@vger.kernel.org>,
        jolsa@redhat.com, jmario@redhat.com, fowles@inreach.com,
        peterz@infradead.org, eranian@google.com, andi.kleen@intel.com
Subject: Re: [PATCH 08/15 V3] perf, c2c: Add stats to track data source bits and cpu to node maps
References: <1395689826-215033-1-git-send-email-dzickus@redhat.com>
	<1395689826-215033-9-git-send-email-dzickus@redhat.com>
Date: Tue, 08 Apr 2014 17:05:56 +0900
In-Reply-To: <1395689826-215033-9-git-send-email-dzickus@redhat.com> (Don
	Zickus's message of "Mon, 24 Mar 2014 15:36:59 -0400")
Message-ID: <87eh18w8ij.fsf@sejong.aot.lge.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org

On Mon, 24 Mar 2014 15:36:59 -0400, Don Zickus wrote:
> This patch adds a bunch of stats that will be used later in post-processing
> to determine where and with what frequency the HITMs are coming from.
>
> Most of the stats are decoded from the data source response.  Another
> piece of the stats is tracking which cpu the record came in on.
>
> Credit to Dick Fowles for determining which bits are important and how to
> properly track them.  Ported to perf by me.
> @@ -187,6 +354,14 @@ static int perf_c2c__process_load_store(struct perf_c2c *c2c,
>  		goto out_mem;
>  	}
>  
> +	err = c2c_decode_stats(&c2c->stats, he);
> +	if (err < 0) {
> +		err = 0;
> +		rb_erase(&he->rb_node_in, c2c->hists.entries_in);
> +		free(he);

Please use hist_entry__free() to free he->mem_info also.

Thanks,
Namhyung


> +		goto out;
> +	}
> +
>  	c2c->hists.stats.total_period += cost;
>  	hists__inc_nr_events(&c2c->hists, PERF_RECORD_SAMPLE);
>  	return err;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/