Message-ID: <1396961103.2812.4.camel@joe-AO722>
Subject: Re: [PATCH v4] Staging: vt6655: iwctl.c: fix a sparse warning
From: Joe Perches <joe@perches.com>
To: Jimmy Li <coder.liss@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Teodora Baluta <teobaluta@gmail.com>,
        Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
        Michael Gunselmann <michael.gunselmann@studium.uni-erlangen.de>,
        Lisa Nguyen <lisa@xenapiadmin.com>,
        Martin Hofmann <martin.hofmann@studium.uni-erlangen.de>,
        Malcolm Priestley <tvboxspy@gmail.com>,
        =?us-ascii?Q?=3D=3Futf-8=3FB=3FVMO8bGluIMSwemVy=3F=3D?= 
	<tulinizer@gmail.com>,
        Archana kumari <archanakumari959@gmail.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Tue, 08 Apr 2014 05:45:03 -0700
In-Reply-To: <20140408110927.GA17308@gmail.com>
References: <20140408110927.GA17308@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 2014-04-08 at 20:36 +0800, Jimmy Li wrote:
> fix a sparse warning and do some clean up.
> 
> Signed-off-by: Jimmy Li <coder.liss@gmail.com>

The --- line should go here

> v1 fix a sparse warning.
> 	(iwctl.c:1846:35: expected restricted gfp_t [usertype] flags)
> v2 clear up two unnecessary variable, buf and blen.
> v3 fix patch format.
> v4 fix patch format again.
> 
> ---

not here

As is, the versioning information would end up
in the changlog and that isn't the desired style.

> diff --git a/drivers/staging/vt6655/iwctl.c b/drivers/staging/vt6655/iwctl.c
[]
> @@ -1835,19 +1835,14 @@ int iwctl_siwencodeext(struct net_device *dev,
[]
> +	param = kzalloc(sizeof(struct viawget_wpa_param), GFP_KERNEL);

Also, param is a struct viawget_wpa_param * so
this should use:

	param = kzalloc(sizeof(*param), GFP_KERNEL);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/