Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756728AbaDHMxO (ORCPT ); Tue, 8 Apr 2014 08:53:14 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:46105 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756369AbaDHMxL (ORCPT ); Tue, 8 Apr 2014 08:53:11 -0400 Message-ID: <5343F0D6.2010804@ti.com> Date: Tue, 8 Apr 2014 15:51:34 +0300 From: Ivan Khoronzhuk User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Brian Norris , , Santosh Shilimkar , CC: , , , , , , , , , , , , Warner Losh Subject: Re: [PATCH v2] mtd: davinci-nand: disable subpage write for keystone-nand References: <1395346112-13350-1-git-send-email-ivan.khoronzhuk@ti.com> <532B4C36.8060405@ti.com> In-Reply-To: <532B4C36.8060405@ti.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/20/2014 10:14 PM, Santosh Shilimkar wrote: > On Thursday 20 March 2014 04:08 PM, Ivan Khoronzhuk wrote: >> From: Murali Karicheri >> >> Sub page write doesn't work because of hw issue in controller found on >> Keystone SOCs. AEMIF controller is also used on DaVinci SOCs which >> don't seems to have any issue. So add "ti,keysone-nand" compatible >> to nand driver in order to set NAND_NO_SUBPAGE_WRITE option. >> >> Cc: Brian Norris >> Cc: Warner Losh >> Cc: Santosh Shilimkar >> >> Signed-off-by: Murali Karicheri >> Signed-off-by: Ivan Khoronzhuk >> --- >> > Acked-by: Santosh Shilimkar > >> This patch is a result of discussion on patch v1: >> https://lkml.org/lkml/2014/3/20/461 >> >> drivers/mtd/nand/davinci_nand.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c >> index 4615d79..b922c8e 100644 >> --- a/drivers/mtd/nand/davinci_nand.c >> +++ b/drivers/mtd/nand/davinci_nand.c >> @@ -523,6 +523,7 @@ static struct nand_ecclayout hwecc4_2048 = { >> #if defined(CONFIG_OF) >> static const struct of_device_id davinci_nand_of_match[] = { >> {.compatible = "ti,davinci-nand", }, >> + {.compatible = "ti,keystone-nand", }, >> {}, >> }; >> MODULE_DEVICE_TABLE(of, davinci_nand_of_match); >> @@ -581,6 +582,11 @@ static struct davinci_nand_pdata >> of_property_read_bool(pdev->dev.of_node, >> "ti,davinci-nand-use-bbt")) >> pdata->bbt_options = NAND_BBT_USE_FLASH; >> + >> + if (of_device_is_compatible(pdev->dev.of_node, >> + "ti,keystone-nand")) { >> + pdata->options |= NAND_NO_SUBPAGE_WRITE; >> + } >> } >> >> return dev_get_platdata(&pdev->dev); >> >> Brian, Could you pick up subj patch? -- Regards, Ivan Khoronzhuk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/