Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932659AbaDHRt6 (ORCPT ); Tue, 8 Apr 2014 13:49:58 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37459 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932615AbaDHRtz (ORCPT ); Tue, 8 Apr 2014 13:49:55 -0400 Date: Tue, 8 Apr 2014 19:49:51 +0200 From: Frederic Weisbecker To: Tony Luck Cc: Linux Kernel Mailing List , Steven Rostedt , Ingo Molnar , Mauro Chehab Subject: Re: [RFC PATCH] time: Fix truncation in jiffies_to_usecs() Message-ID: <20140408174946.GA11121@localhost.localdomain> References: <0214020@agluck-desk.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 07, 2014 at 10:34:51PM -0700, Tony Luck wrote: > On Mon, Apr 7, 2014 at 3:25 PM, Tony Luck wrote: > > > c) If not this ... then what? Separate routine to convert large numbers > > of jiffies to usec/nsecs? Should we make the existing one barf when > > handed a number that overflows? > > Having thought about this a bit more - I'm leaning towards leaving > jiffies_to_usecs() alone, but using it as a model for a from-scratch > implementation of: > u64 jiffies_to_nsecs(const unsigned long j) > { > } > > This is what the uptime tracer actually needs - and there is only > one user of jiffies_to_nsecs() to worry about. I'm not sure I get what you're trying to do. We already have jiffies_to_nsecs(). Anyway I'll just wait and check out the next patch :) Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/