Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932503AbaDIARj (ORCPT ); Tue, 8 Apr 2014 20:17:39 -0400 Received: from mail.active-venture.com ([67.228.131.205]:57960 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932352AbaDIARi (ORCPT ); Tue, 8 Apr 2014 20:17:38 -0400 X-Originating-IP: 108.223.40.66 Message-ID: <5344919E.9030708@roeck-us.net> Date: Tue, 08 Apr 2014 17:17:34 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: David Cohen , wim@iguana.be, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org CC: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk, Eric Ernst Subject: Re: [PATCH 1/2] watchdog: add Intel MID watchdog driver support References: <1396990744-10695-1-git-send-email-david.a.cohen@linux.intel.com> <1396990744-10695-2-git-send-email-david.a.cohen@linux.intel.com> In-Reply-To: <1396990744-10695-2-git-send-email-david.a.cohen@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/2014 01:59 PM, David Cohen wrote: > Add initial Intel MID watchdog driver support. > > This driver is an initial implementation of generic Intel MID watchdog > driver. Currently it supports Intel Merrifield platform. How does this compare with the existing SCU watchdog driver (intel_scu_watchdog) ? The watchdog IPC message (0xf8) seems to be the same, so there must be at least some overlap. Would it be possible to have just one watchdog driver serving the different SCU based devices ? > > Signed-off-by: Eric Ernst > Signed-off-by: David Cohen > --- > drivers/watchdog/Kconfig | 12 +++ > drivers/watchdog/Makefile | 1 + > drivers/watchdog/intel-mid_wdt.c | 209 +++++++++++++++++++++++++++++++++++++++ > 3 files changed, 222 insertions(+) > create mode 100644 drivers/watchdog/intel-mid_wdt.c > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 79d25894343a..4da09b8b2f11 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -643,6 +643,18 @@ config INTEL_SCU_WATCHDOG > > To compile this driver as a module, choose M here. > > +config INTEL_MID_WATCHDOG > + bool "Intel MID SCU Watchdog Mobile Platforms" > + depends on X86_INTEL_MID && WATCHDOG_CORE All other watchdog drivers using the watchdog core use select WATCHDOG_CORE so this one should do the same. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/