Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758311AbaDIHgM (ORCPT ); Wed, 9 Apr 2014 03:36:12 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48338 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752444AbaDIHgK (ORCPT ); Wed, 9 Apr 2014 03:36:10 -0400 Date: Wed, 09 Apr 2014 09:36:08 +0200 Message-ID: From: Takashi Iwai To: Dylan Reid Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda - Use runtime helper to check active state. In-Reply-To: <1396983978-12907-1-git-send-email-dgreid@chromium.org> References: <1396983978-12907-1-git-send-email-dgreid@chromium.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 8 Apr 2014 12:06:18 -0700, Dylan Reid wrote: > > >From azx_interrupt, use the helper to check if the device is active > instead of checking the state. This will do the right thing if > runtime pm is disabled in addition to if the device is suspended. > > Signed-off-by: Dylan Reid Thanks, applied. Takashi > --- > sound/pci/hda/hda_controller.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c > index 97993e1..460fcf4 100644 > --- a/sound/pci/hda/hda_controller.c > +++ b/sound/pci/hda/hda_controller.c > @@ -1758,7 +1758,7 @@ irqreturn_t azx_interrupt(int irq, void *dev_id) > > #ifdef CONFIG_PM_RUNTIME > if (chip->driver_caps & AZX_DCAPS_PM_RUNTIME) > - if (chip->card->dev->power.runtime_status != RPM_ACTIVE) > + if (!pm_runtime_active(chip->card->dev)) > return IRQ_NONE; > #endif > > -- > 1.8.1.3.605.g02339dd > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/