Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758185AbaDIHse (ORCPT ); Wed, 9 Apr 2014 03:48:34 -0400 Received: from 1wt.eu ([62.212.114.60]:3699 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbaDIHsd (ORCPT ); Wed, 9 Apr 2014 03:48:33 -0400 Date: Wed, 9 Apr 2014 09:47:52 +0200 From: Willy Tarreau To: Thomas Petazzoni Cc: Jason Gunthorpe , Neil Greatorex , linux-arm-kernel@lists.infradead.org, Matthew Minter , linux-kernel@vger.kernel.org, Jason Cooper Subject: Re: [PATCH v2] bus: mvebu-mbus: Avoid setting an undefined window size Message-ID: <20140409074752.GF16465@1wt.eu> References: <1397000654-10849-1-git-send-email-jgunthorpe@obsidianresearch.com> <20140409061128.GC16465@1wt.eu> <20140409091234.20f2e547@skate> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140409091234.20f2e547@skate> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 09, 2014 at 09:12:34AM +0200, Thomas Petazzoni wrote: > Dear Willy Tarreau, > > On Wed, 9 Apr 2014 08:11:29 +0200, Willy Tarreau wrote: > > > The WARN is correctly emitted for both igb ports here, but unfortunately > > despite EINVAL, I still get the panic. Also I find it surprizing that it > > reports sizes ending in ffff. I read the patch and it looks correct, so > > we possibly have something else wrong here. > > Yes, the panic is expected: Jason's patch is not *fixing* anything, > it's just telling you *why* it's going to panic. I just thought that the EINVAL would prevent one from registering the device, which would be more useful (if at all possible). Willy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/