Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932913AbaDILDt (ORCPT ); Wed, 9 Apr 2014 07:03:49 -0400 Received: from mail.skyhub.de ([78.46.96.112]:38446 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757645AbaDILDq (ORCPT ); Wed, 9 Apr 2014 07:03:46 -0400 Date: Wed, 9 Apr 2014 13:03:39 +0200 From: Borislav Petkov To: punnaiah choudary kalluri Cc: Punnaiah Choudary Kalluri , dougthompson@xmission.com, linux-edac@vger.kernel.org, "michal.simek@xilinx.com" , "robh+dt@kernel.org" , "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , Kumar Gala , Rob Landley , sorenb@xilinx.com, "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , linux-arm-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" , Punnaiah Choudary Subject: Re: [RFC PATCH v2] edac: synopsys: Added EDAC support for zynq ddr ecc controller Message-ID: <20140409110339.GF6529@pd.tnic> References: <1220b715-6fc2-42ed-8393-b9859fc0deb9@TX2EHSMHS021.ehs.local> <20140408204047.GQ30077@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 09, 2014 at 11:34:31AM +0530, punnaiah choudary kalluri wrote: > Since it is recommended in Documentation/kernel-doc-nano-HOWTO.txt > but also said it is low priority and at the discretion of the MAINTAINER of > that kernel source file > > So, if you recommend not use kernel-doc annotation then i will take care > in next version. I don't think there's need for documenting those functions for kernel-doc - it is an EDAC driver and not some subsystem function with a lot of users. > devm_ioremap_resource function will check this condition, so not > checking for the NULL explicitly And it would say dev_err(dev, "invalid resource\n"); so we'll know what fails, ok. > Since the probe returns error, it it that the devm_ framework will > clean these resources automatically? Ah, that's the managed thing, ok. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/