Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933195AbaDILV2 (ORCPT ); Wed, 9 Apr 2014 07:21:28 -0400 Received: from prifuk.cz ([31.31.77.140]:52602 "EHLO devoid-pointer.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932781AbaDILVX convert rfc822-to-8bit (ORCPT ); Wed, 9 Apr 2014 07:21:23 -0400 From: Michal =?ISO-8859-1?Q?Mal=FD?= To: dmitry.torokhov@gmail.com, jkosina@suse.cz Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Elias Vanderstuyft Subject: [PATCH 09/24] Port hid-dr to ff-memless-next Date: Wed, 09 Apr 2014 13:21:19 +0200 Message-ID: <2752125.4xvuu9j6kv@sigyn> User-Agent: KMail/4.13 rc (Linux/3.14.0-1-ARCHMOD; KDE/4.12.97; x86_64; ; ) In-Reply-To: <1609685.QRL9N9sQvX@sigyn> References: <1609685.QRL9N9sQvX@sigyn> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Port hid-dr to ff-memless-next Signed-off-by: Michal Mal? --- drivers/hid/Kconfig | 2 +- drivers/hid/hid-dr.c | 59 ++++++++++++++++++++++++++++++++-------------------- 2 files changed, 37 insertions(+), 24 deletions(-) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 6e233d2..0ba1962 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -196,7 +196,7 @@ config HID_DRAGONRISE config DRAGONRISE_FF bool "DragonRise Inc. force feedback" depends on HID_DRAGONRISE - select INPUT_FF_MEMLESS + select INPUT_FF_MEMLESS_NEXT ---help--- Say Y here if you want to enable force feedback support for DragonRise Inc. game controllers. diff --git a/drivers/hid/hid-dr.c b/drivers/hid/hid-dr.c index ce06444..b95c676 100644 --- a/drivers/hid/hid-dr.c +++ b/drivers/hid/hid-dr.c @@ -31,8 +31,10 @@ #include #include #include +#include #include "hid-ids.h" +#define FF_UPDATE_RATE 50 #ifdef CONFIG_DRAGONRISE_FF @@ -41,38 +43,49 @@ struct drff_device { }; static int drff_play(struct input_dev *dev, void *data, - struct ff_effect *effect) + const struct mlnx_effect_command *command) { struct hid_device *hid = input_get_drvdata(dev); struct drff_device *drff = data; + const struct mlnx_rumble_force *rumble_force = &command->u.rumble_force; int strong, weak; - strong = effect->u.rumble.strong_magnitude; - weak = effect->u.rumble.weak_magnitude; + strong = rumble_force->strong; + weak = rumble_force->weak; dbg_hid("called with 0x%04x 0x%04x", strong, weak); - if (strong || weak) { - strong = strong * 0xff / 0xffff; - weak = weak * 0xff / 0xffff; - - /* While reverse engineering this device, I found that when - this value is set, it causes the strong rumble to function - at a near maximum speed, so we'll bypass it. */ - if (weak == 0x0a) - weak = 0x0b; - - drff->report->field[0]->value[0] = 0x51; - drff->report->field[0]->value[1] = 0x00; - drff->report->field[0]->value[2] = weak; - drff->report->field[0]->value[4] = strong; - hid_hw_request(hid, drff->report, HID_REQ_SET_REPORT); - - drff->report->field[0]->value[0] = 0xfa; - drff->report->field[0]->value[1] = 0xfe; - } else { + switch (command->cmd) { + case MLNX_START_RUMBLE: + if (strong || weak) { + strong = strong * 0xff / 0xffff; + weak = weak * 0xff / 0xffff; + + /* While reverse engineering this device, I found that when + this value is set, it causes the strong rumble to function + at a near maximum speed, so we'll bypass it. */ + if (weak == 0x0a) + weak = 0x0b; + + drff->report->field[0]->value[0] = 0x51; + drff->report->field[0]->value[1] = 0x00; + drff->report->field[0]->value[2] = weak; + drff->report->field[0]->value[4] = strong; + hid_hw_request(hid, drff->report, HID_REQ_SET_REPORT); + + drff->report->field[0]->value[0] = 0xfa; + drff->report->field[0]->value[1] = 0xfe; + } else { + drff->report->field[0]->value[0] = 0xf3; + drff->report->field[0]->value[1] = 0x00; + } + break; + case MLNX_STOP_RUMBLE: drff->report->field[0]->value[0] = 0xf3; drff->report->field[0]->value[1] = 0x00; + break; + default: + return -EINVAL; } drff->report->field[0]->value[2] = 0x00; @@ -116,7 +129,7 @@ static int drff_init(struct hid_device *hid) set_bit(FF_RUMBLE, dev->ffbit); - error = input_ff_create_memless(dev, drff, drff_play); + error = input_ff_create_mlnx(dev, drff, drff_play, FF_UPDATE_RATE); if (error) { kfree(drff); return error; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/