Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933014AbaDILlt (ORCPT ); Wed, 9 Apr 2014 07:41:49 -0400 Received: from mail-qg0-f50.google.com ([209.85.192.50]:46977 "EHLO mail-qg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758486AbaDILlp (ORCPT ); Wed, 9 Apr 2014 07:41:45 -0400 MIME-Version: 1.0 In-Reply-To: <53452B59.8030901@samsung.com> References: <1396967803-28868-1-git-send-email-gautam.vivek@samsung.com> <1396967803-28868-6-git-send-email-gautam.vivek@samsung.com> <53452B59.8030901@samsung.com> Date: Wed, 9 Apr 2014 17:04:46 +0530 X-Google-Sender-Auth: UR8JIOvgxeA_Yr-KfpfOlekClDc Message-ID: Subject: Re: [PATCH V4 5/5] usb-phy: samsung-usb3: Remove older phy-samsung-usb3 driver From: Vivek Gautam To: Tomasz Figa Cc: Linux USB Mailing List , "linux-samsung-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , linux-doc@vger.kernel.org, kishon , Greg KH , Felipe Balbi , Kukjin Kim , Kamil Debski , Jingoo Han , Sylwester Nawrocki Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tomasz, ' On Wed, Apr 9, 2014 at 4:43 PM, Tomasz Figa wrote: > Hi Vivek, > Thanks for reviewing the patch series. > > On 08.04.2014 16:36, Vivek Gautam wrote: >> >> Removing this older USB 3.0 DRD controller PHY driver, since >> a new driver based on generic phy framework is now available. >> >> Also removing the dt node for older driver from Exynos5250 >> device tree and updating the dt node for DWC3 controller. >> >> Signed-off-by: Vivek Gautam >> --- >> >> NOTE: This patch should be merged only when the new USB 3.0 >> DRD phy controller driver is available in the tree from the >> patches: >> phy: Add new Exynos5 USB 3.0 PHY driver; and >> dt: exynos5250: Enable support for generic USB DRD phy >> >> arch/arm/boot/dts/exynos5250.dtsi | 17 +- >> drivers/usb/phy/phy-samsung-usb.h | 83 --------- >> drivers/usb/phy/phy-samsung-usb3.c | 350 >> ------------------------------------ >> 3 files changed, 2 insertions(+), 448 deletions(-) >> delete mode 100644 drivers/usb/phy/phy-samsung-usb3.c >> >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi >> b/arch/arm/boot/dts/exynos5250.dtsi >> index 92c6fcd..1cb1e91 100644 >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi > > > IMHO driver and dts changes should be separated into two patches, first > updating device tree to use the new driver and second removing the driver. Sure will separate the patch into driver and dts change. > > After fixing this issue, > > Reviewed-by: Tomasz Figa > > -- > Best regards, > Tomasz > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/