Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933365AbaDIOnp (ORCPT ); Wed, 9 Apr 2014 10:43:45 -0400 Received: from top.free-electrons.com ([176.31.233.9]:33101 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932786AbaDIOnm (ORCPT ); Wed, 9 Apr 2014 10:43:42 -0400 Message-ID: <53455C9C.1040607@free-electrons.com> Date: Wed, 09 Apr 2014 16:43:40 +0200 From: Boris BREZILLON User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Emilio_L=F3pez?= , Randy Dunlap , Maxime Ripard , Mike Turquette , Linus Walleij CC: devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/15] ARM: sunxi: dt: define A31's APB0 clk gates node References: <1397051478-4113-1-git-send-email-boris.brezillon@free-electrons.com> <1397051478-4113-8-git-send-email-boris.brezillon@free-electrons.com> <534553FF.4060401@elopez.com.ar> In-Reply-To: <534553FF.4060401@elopez.com.ar> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/04/2014 16:06, Emilio L?pez wrote: > Hi Boris, > > El 09/04/14 10:51, Boris BREZILLON escribi?: >> Define the APB0 clk gates controlled by the PRCM (Power/Reset/Clock >> Management) block. >> >> Signed-off-by: Boris BREZILLON >> --- >> arch/arm/boot/dts/sun6i-a31.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi >> b/arch/arm/boot/dts/sun6i-a31.dtsi >> index 3858424..61e8b34 100644 >> --- a/arch/arm/boot/dts/sun6i-a31.dtsi >> +++ b/arch/arm/boot/dts/sun6i-a31.dtsi >> @@ -141,6 +141,16 @@ >> "ahb1_drc0", "ahb1_drc1"; >> }; >> >> + apb0_gates: apb0_gates@01f01428 { > > Looks like this node is out of place, judging by the address. Try to > keep them in order. Sure, I'll fix it for the next version. > >> + #clock-cells = <1>; >> + compatible = "allwinner,sun6i-a31-apb0-gates-clk"; >> + reg = <0x01f01428 0x4>; >> + clock-output-names = "apb0_pio", "apb0_ir", >> + "apb0_timer01", "apb0_p2wi", >> + "apb0_uart", "apb0_1wire", >> + "apb0_i2c"; >> + }; >> + >> apb1: apb1@01c20054 { >> #clock-cells = <0>; >> compatible = "allwinner,sun4i-apb0-clk"; >> > > Cheers, > > Emilio -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/