Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933975AbaDIPVG (ORCPT ); Wed, 9 Apr 2014 11:21:06 -0400 Received: from mail-ob0-f175.google.com ([209.85.214.175]:57046 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933256AbaDIPVA (ORCPT ); Wed, 9 Apr 2014 11:21:00 -0400 MIME-Version: 1.0 In-Reply-To: <20140409103138.29be16b9@gandalf.local.home> References: <20131113113927.GA13875@mwhitehe.csb> <20131113102153.5f10e6b5@gandalf.local.home> <20131113103134.5b8cf02f@gandalf.local.home> <20131113105737.3f7a0b1b@gandalf.local.home> <20131113111257.482c2955@gandalf.local.home> <20131113161829.GE4138@linux.vnet.ibm.com> <20131113112338.7d303c0f@gandalf.local.home> <20131113163552.GF4138@linux.vnet.ibm.com> <20140409103138.29be16b9@gandalf.local.home> Date: Wed, 9 Apr 2014 20:50:59 +0530 Message-ID: Subject: Re: nohz problem with idle time on old hardware From: Viresh Kumar To: Steven Rostedt Cc: Thomas Gleixner , "Paul E. McKenney" , Matthew Whitehead , John Stultz , "linux-kernel@vger.kernel.org" , mwhitehe@redhat.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9 April 2014 20:01, Steven Rostedt wrote: > Ouch! You are correct, this part of the patch makes no sense. That's > what I get for reviewing a patch and not looking at all the code around > the changes. (another kernel developer hangs head in shame :-( ) > > I think that if statement should be nuked. Hmm, my opinion differs here :) If we completely remove this statement, we will run tick_nohz_switch_to_nohz() even if nohz is not enabled. And check for enabled must stay. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/