Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934008AbaDIRNJ (ORCPT ); Wed, 9 Apr 2014 13:13:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6135 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933686AbaDIRNH (ORCPT ); Wed, 9 Apr 2014 13:13:07 -0400 Date: Wed, 9 Apr 2014 19:12:51 +0200 From: Oleg Nesterov To: Frederic Weisbecker Cc: LKML , Andrew Morton , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH 1/5] sched: Convert thread_group_cputime() to use for_each_thread() Message-ID: <20140409171251.GD27638@redhat.com> References: <1397059882-23063-1-git-send-email-fweisbec@gmail.com> <1397059882-23063-2-git-send-email-fweisbec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1397059882-23063-2-git-send-email-fweisbec@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/09, Frederic Weisbecker wrote: > > @@ -295,16 +295,15 @@ void thread_group_cputime(struct task_struct *tsk, struct task_cputime *times) > > rcu_read_lock(); > /* make sure we can trust tsk->thread_group list */ > - if (!likely(pid_alive(tsk))) > + if (!likely(pid_alive(p))) You can simply remove this check now. for_each_thread() is always safe. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/