Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965048AbaDIUm0 (ORCPT ); Wed, 9 Apr 2014 16:42:26 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:60112 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934010AbaDIUmW (ORCPT ); Wed, 9 Apr 2014 16:42:22 -0400 MIME-Version: 1.0 In-Reply-To: <1396631237-11813-1-git-send-email-tolga@cevel.net> References: <1396631237-11813-1-git-send-email-tolga@cevel.net> Date: Wed, 9 Apr 2014 16:42:21 -0400 Message-ID: Subject: Re: [PATCH 4/4] HID: microsoft: undefining ms_map_key_clear after usage From: Benjamin Tissoires To: Tolga Cakir Cc: Benjamin Tissoires , Derya , Jiri Kosina , Reyad Attiyat , linux-input , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 4, 2014 at 1:07 PM, Tolga Cakir wrote: > This is inspired by various other hid drivers. > > Signed-off-by: Tolga Cakir > --- > drivers/hid/hid-microsoft.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c > index 5674c0c..5281d2d 100644 > --- a/drivers/hid/hid-microsoft.c > +++ b/drivers/hid/hid-microsoft.c > @@ -211,6 +211,8 @@ static int ms_sidewinder_kb_quirk(struct hid_input *hi, struct hid_usage *usage, > return 1; > } > > +#undef ms_map_key_clear > + Not sure this is really needed. The macro is prefixed by ms_, so I will simply let it there. Cheers, Benjamin > static int ms_sidewinder_control(struct hid_device *hdev, __u8 setup) > { > struct ms_data *sc = hid_get_drvdata(hdev); > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/