Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758436AbaDJGQb (ORCPT ); Thu, 10 Apr 2014 02:16:31 -0400 Received: from mail1.bemta5.messagelabs.com ([195.245.231.145]:36585 "EHLO mail1.bemta5.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750861AbaDJGQa (ORCPT ); Thu, 10 Apr 2014 02:16:30 -0400 X-Env-Sender: Johannes.Thumshirn@men.de X-Msg-Ref: server-5.tower-179.messagelabs.com!1397110586!30262008!1 X-Originating-IP: [80.255.6.145] X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked X-PGP-Universal: processed; by keys.men.de on Thu, 10 Apr 2014 08:16:27 +0200 Date: Thu, 10 Apr 2014 08:16:20 +0200 From: Johannes Thumshirn To: Christoph Jaeger CC: , Subject: Re: [PATCH] drivers: mcb: fix memory leak in chameleon_parse_cells() error path Message-ID: <20140410061620.GA6278@jtlinux> References: <1396638298-3173-1-git-send-email-christophjaeger@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1396638298-3173-1-git-send-email-christophjaeger@linux.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [192.1.1.31] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 04, 2014 at 09:04:58PM +0200, Christoph Jaeger wrote: > chameleon_parse_cells() bails out if chameleon descriptor type is > invalid but does not free the storage 'header' points to. > > Signed-off-by: Christoph Jaeger > --- > drivers/mcb/mcb-parse.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c > index d1278b5..0049269 100644 > --- a/drivers/mcb/mcb-parse.c > +++ b/drivers/mcb/mcb-parse.c > @@ -141,6 +141,7 @@ int chameleon_parse_cells(struct mcb_bus *bus, phys_addr_t mapbase, > default: > pr_err("Invalid chameleon descriptor type 0x%x\n", > dtype); > + kfree(header); > return -EINVAL; > } > num_cells++; > -- > 1.9.0 > Hi, Your patch has been applied to my repo located at: https://github.com/morbidrsa/linux/tree/mcb or git://github.com/morbidrsa/linux.git Thanks, Johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/