Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965693AbaDJKVy (ORCPT ); Thu, 10 Apr 2014 06:21:54 -0400 Received: from fw-tnat.austin.arm.com ([217.140.110.23]:15601 "EHLO collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934855AbaDJKVv (ORCPT ); Thu, 10 Apr 2014 06:21:51 -0400 From: Marc Zyngier To: armdev Cc: Chanwoo Choi , "kgene.kim\@samsung.com" , "t.figa\@samsung.com" , "linux-samsung-soc\@vger.kernel.org" , "hyunhee.kim\@samsung.com" , "sw0312.kim\@samsung.com" , "linux-kernel\@vger.kernel.org" , "yj44.cho\@samsung.com" , "inki.dae\@samsung.com" , "kyungmin.park\@samsung.com" , Thomas Gleixner , "linux-arm-kernel\@lists.infradead.org" , Mark Rutland Subject: Re: [PATCH 07/27] irqchip: Declare cortex-a7's irqchip to initialize gic from dt In-Reply-To: (armdev's message of "Thu, 10 Apr 2014 11:09:02 +0100") Organization: ARM Ltd References: <1397122124-15690-1-git-send-email-cw00.choi@samsung.com> <1397122124-15690-8-git-send-email-cw00.choi@samsung.com> <878urd33g4.fsf@approximate.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) Date: Thu, 10 Apr 2014 11:21:43 +0100 Message-ID: <874n2132o8.fsf@approximate.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 10 2014 at 11:09:02 am BST, armdev wrote: > On 10-Apr-2014, at 3:34 pm, Marc Zyngier wrote: > >> On Thu, Apr 10 2014 at 10:28:24 am BST, Chanwoo Choi wrote: >>> This patch declare coretex-a7's irqchip to initialze gic from dt >>> with "arm,cortex-a7-gic" data. >>> >>> Cc: Thomas Gleixner >>> Signed-off-by: Chanwoo Choi >>> Signed-off-by: Kyungmin Park >>> --- >>> drivers/irqchip/irq-gic.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c >>> index 4300b66..8e906e4 100644 >>> --- a/drivers/irqchip/irq-gic.c >>> +++ b/drivers/irqchip/irq-gic.c >>> @@ -1069,6 +1069,7 @@ gic_of_init(struct device_node *node, struct device_node *parent) >>> } >>> IRQCHIP_DECLARE(cortex_a15_gic, "arm,cortex-a15-gic", gic_of_init); >>> IRQCHIP_DECLARE(cortex_a9_gic, "arm,cortex-a9-gic", gic_of_init); >>> +IRQCHIP_DECLARE(cortex_a7_gic, "arm,cortex-a7-gic", gic_of_init); >>> IRQCHIP_DECLARE(msm_8660_qgic, "qcom,msm-8660-qgic", gic_of_init); >>> IRQCHIP_DECLARE(msm_qgic2, "qcom,msm-qgic2", gic_of_init); >> >> Frankly, this patch adds no value. Are we going to add >> "arm,cortex-a12-gic", "arm,cortex-a17-gic", "arm,cortex-a53-gic", >> "arm,cortex-a57-gic"? And that's just to mention the ARM Ltd cores... >> >> Instead, how about defining a generic "arm,gic" property, and mandate >> that new DT files are using that? We can always use a more precise >> compatible for quirks. >> > > How about keeping it simple and tied to arm gic versions > arm,gicv1, arm,gicv2, arm,gicv2ve That's a variation on the same theme. As for GICv2, we don't need to distinguish between having the Virtualization Extentions, the binding already allows you to tell one from the other. M. -- Jazz is not dead. It just smells funny. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/