Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030838AbaDJNDf (ORCPT ); Thu, 10 Apr 2014 09:03:35 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:54494 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030588AbaDJNDe (ORCPT ); Thu, 10 Apr 2014 09:03:34 -0400 Date: Thu, 10 Apr 2014 14:02:59 +0100 From: Mark Rutland To: Marc Zyngier Cc: Chanwoo Choi , "kgene.kim@samsung.com" , "t.figa@samsung.com" , "linux-samsung-soc@vger.kernel.org" , "hyunhee.kim@samsung.com" , "sw0312.kim@samsung.com" , "linux-kernel@vger.kernel.org" , "yj44.cho@samsung.com" , "inki.dae@samsung.com" , "kyungmin.park@samsung.com" , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 07/27] irqchip: Declare cortex-a7's irqchip to initialize gic from dt Message-ID: <20140410130259.GA4462@e106331-lin.cambridge.arm.com> References: <1397122124-15690-1-git-send-email-cw00.choi@samsung.com> <1397122124-15690-8-git-send-email-cw00.choi@samsung.com> <878urd33g4.fsf@approximate.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878urd33g4.fsf@approximate.cambridge.arm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 10, 2014 at 11:04:59AM +0100, Marc Zyngier wrote: > On Thu, Apr 10 2014 at 10:28:24 am BST, Chanwoo Choi wrote: > > This patch declare coretex-a7's irqchip to initialze gic from dt > > with "arm,cortex-a7-gic" data. > > > > Cc: Thomas Gleixner > > Signed-off-by: Chanwoo Choi > > Signed-off-by: Kyungmin Park > > --- > > drivers/irqchip/irq-gic.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c > > index 4300b66..8e906e4 100644 > > --- a/drivers/irqchip/irq-gic.c > > +++ b/drivers/irqchip/irq-gic.c > > @@ -1069,6 +1069,7 @@ gic_of_init(struct device_node *node, struct device_node *parent) > > } > > IRQCHIP_DECLARE(cortex_a15_gic, "arm,cortex-a15-gic", gic_of_init); > > IRQCHIP_DECLARE(cortex_a9_gic, "arm,cortex-a9-gic", gic_of_init); > > +IRQCHIP_DECLARE(cortex_a7_gic, "arm,cortex-a7-gic", gic_of_init); > > IRQCHIP_DECLARE(msm_8660_qgic, "qcom,msm-8660-qgic", gic_of_init); > > IRQCHIP_DECLARE(msm_qgic2, "qcom,msm-qgic2", gic_of_init); > > Frankly, this patch adds no value. Are we going to add > "arm,cortex-a12-gic", "arm,cortex-a17-gic", "arm,cortex-a53-gic", > "arm,cortex-a57-gic"? And that's just to mention the ARM Ltd cores... > > Instead, how about defining a generic "arm,gic" property, and mandate > that new DT files are using that? We can always use a more precise > compatible for quirks. Nit: s/property/compatible/ As mentioned elsewhere, "arm,gic-v2" would seem to fit the bill (and we can have "arm,gic" or "arm,gic-v1" for v1). > Mark, what do you think? I think this has been discussed in the past > already. It's been repeatedly brought up and agreed on, it's just that no-one's implemented it. I agree that having an "arm,gic-v2" binding that people can place in their compatible list is a sensible thing to do, and I'd be happy to Ack patches implementing it. Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/