Message-ID: <53469970.6030405@hitachi.com>
Date: Thu, 10 Apr 2014 22:15:28 +0900
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Organization: Hitachi, Ltd., Japan
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
        Anton Arapov <aarapov@redhat.com>, David Long <dave.long@linaro.org>,
        "Frank Ch. Eigler" <fche@redhat.com>,
        Jim Keniston <jkenisto@us.ibm.com>, Jonathan Lebon <jlebon@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 4/6] uprobes/x86: Emulate rip-relative call's
References: <20140409194434.GA6235@redhat.com> <5346944F.2040709@redhat.com>
In-Reply-To: <5346944F.2040709@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

(2014/04/10 21:53), Denys Vlasenko wrote:
> On 04/09/2014 09:44 PM, Oleg Nesterov wrote:
>> +static void ttt_clear_displacement(struct arch_uprobe *auprobe, struct insn *insn)
> 
> Branch instruction's offset isn't called "displacement"
> on x86.
> 
> How about ttt_clear_branch_offset?

I like his idea. "displacement" on x86 is so confused especially
with using x86 insn decoder.

Thank you,

> 
>> +{
>> +	/*
>> +	 * Turn this insn into "call 1f; 1:", this is what we will execute
>> +	 * out-of-line if ->emulate() fails.
>> +	 *
>> +	 * In the likely case this will lead to arch_uprobe_abort_xol(), but
>> +	 * see the comment in ->emulate(). So we need to ensure that the new
>> +	 * ->ip can't fall into non-canonical area and trigger #GP.
>> +	 *
>> +	 * We could turn it into (say) "pushf", but then we would need to
>> +	 * divorce ->insn[] and ->ixol[]. We need to preserve the 1st byte
>> +	 * of ->insn[] for set_orig_insn().
>> +	 */
>> +	memset(auprobe->insn + insn_offset_immediate(insn),
>> +		0, insn->immediate.nbytes);
>> +}
> 
> 


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/