Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935568AbaDJO1b (ORCPT ); Thu, 10 Apr 2014 10:27:31 -0400 Received: from mail-ve0-f176.google.com ([209.85.128.176]:35130 "EHLO mail-ve0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934688AbaDJO13 (ORCPT ); Thu, 10 Apr 2014 10:27:29 -0400 MIME-Version: 1.0 In-Reply-To: <1397137433-19106-1-git-send-email-chander.kashyap@linaro.org> References: <1397137433-19106-1-git-send-email-chander.kashyap@linaro.org> Date: Thu, 10 Apr 2014 17:27:28 +0300 Message-ID: Subject: Re: [PATCH] cpuidle: governor: menu: move repeated correction factor check to init From: Tuukka Tikkanen To: Chander Kashyap Cc: "linux-kernel@vger.kernel.org" , rafael.j.wysocki@intel.com, Daniel Lezcano Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10 April 2014 16:43, Chander Kashyap wrote: > In menu_select function we check for correction factor every time. > If it is zero we are initializing to unity. Hence move it to init function > and initialise by unity, hence avoid repeated comparisons. > > Signed-off-by: Chander Kashyap > --- > drivers/cpuidle/governors/menu.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c > index cf7f2f0..048f6d9 100644 > --- a/drivers/cpuidle/governors/menu.c > +++ b/drivers/cpuidle/governors/menu.c > @@ -315,13 +315,6 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) > multiplier = performance_multiplier(); > > /* > - * if the correction factor is 0 (eg first time init or cpu hotplug > - * etc), we actually want to start out with a unity factor. > - */ > - if (data->correction_factor[data->bucket] == 0) > - data->correction_factor[data->bucket] = RESOLUTION * DECAY; > - > - /* > * Force the result of multiplication to be 64 bits even if both > * operands are 32 bits. > * Make sure to round up for half microseconds. > @@ -453,9 +446,17 @@ static int menu_enable_device(struct cpuidle_driver *drv, > struct cpuidle_device *dev) > { > struct menu_device *data = &per_cpu(menu_devices, dev->cpu); > + int i; > > memset(data, 0, sizeof(struct menu_device)); > > + /* > + * if the correction factor is 0 (eg first time init or cpu hotplug > + * etc), we actually want to start out with a unity factor. > + */ > + for(i = 0; i < BUCKETS; i++) > + data->correction_factor[i] = RESOLUTION * DECAY; > + > return 0; > } > > -- > 1.7.9.5 > Reviewed-by: Tuukka Tikkanen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/