Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030572AbaDJP15 (ORCPT ); Thu, 10 Apr 2014 11:27:57 -0400 Received: from netrider.rowland.org ([192.131.102.5]:59785 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1030527AbaDJP1y (ORCPT ); Thu, 10 Apr 2014 11:27:54 -0400 Date: Thu, 10 Apr 2014 11:27:52 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Vivek Gautam cc: linux-usb@vger.kernel.org, , , , , , , Hauke Mehrtens , Hans de Goede Subject: Re: [PATCH v2 2/2] usb: ehci-platform: Return immediately from suspend if ehci_suspend fails In-Reply-To: <1397125682-4955-2-git-send-email-gautam.vivek@samsung.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Apr 2014, Vivek Gautam wrote: > Patch 'b8efdaf USB: EHCI: add check for wakeup/suspend race' > adds a check for possible race between suspend and wakeup interrupt, > and thereby it returns -EBUSY as error code if there's a wakeup > interrupt. > So the platform host controller should not proceed further with > its suspend callback, rather should return immediately to avoid > powering down the essential things, like phy. > > Signed-off-by: Vivek Gautam > Cc: Alan Stern > Cc: Hauke Mehrtens > Cc: Hans de Goede > --- > > Changes from v1: > -- Removed unnecessary change 'return 0' > > drivers/usb/host/ehci-platform.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c > index b3a0e11..c7dd93a 100644 > --- a/drivers/usb/host/ehci-platform.c > +++ b/drivers/usb/host/ehci-platform.c > @@ -303,6 +303,8 @@ static int ehci_platform_suspend(struct device *dev) > int ret; > > ret = ehci_suspend(hcd, do_wakeup); > + if (ret) > + return ret; > > if (pdata->power_suspend) > pdata->power_suspend(pdev); Acked-by: Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/