Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758832AbaDJRfR (ORCPT ); Thu, 10 Apr 2014 13:35:17 -0400 Received: from mail-oa0-f54.google.com ([209.85.219.54]:53035 "EHLO mail-oa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758514AbaDJRfP (ORCPT ); Thu, 10 Apr 2014 13:35:15 -0400 MIME-Version: 1.0 In-Reply-To: <1396865589-9972-2-git-send-email-bigeasy@linutronix.de> References: <1396865589-9972-1-git-send-email-bigeasy@linutronix.de> <1396865589-9972-2-git-send-email-bigeasy@linutronix.de> Date: Thu, 10 Apr 2014 19:35:14 +0200 Message-ID: Subject: Re: [PATCH 1/5] gpio: dwapb: drop irq_setup_generic_chip() From: Linus Walleij To: Sebastian Andrzej Siewior Cc: Jamie Iles , Alan Tull , Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Dinh Nguyen , Sebastian Hesselbarth Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 7, 2014 at 12:13 PM, Sebastian Andrzej Siewior wrote: > The driver calls irq_alloc_domain_generic_chips() which creates a gc and > adds it to gc_list. The driver later then calls irq_setup_generic_chip() > which also initializes the gc and adds it to the gc_list() and this > corrupts the list. Enable LIST_DEBUG and you see the kernel complain. > This isn't required, irq_alloc_domain_generic_chips() did the init. > > Signed-off-by: Sebastian Andrzej Siewior Patch applied, adding Alan Tull's Tested-by. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/