Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751107AbaDKEB5 (ORCPT ); Fri, 11 Apr 2014 00:01:57 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:35965 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993AbaDKEBz (ORCPT ); Fri, 11 Apr 2014 00:01:55 -0400 MIME-Version: 1.0 In-Reply-To: <1397124377-16969-2-git-send-email-cw00.choi@samsung.com> References: <1397122658-16013-1-git-send-email-cw00.choi@samsung.com> <1397124377-16969-2-git-send-email-cw00.choi@samsung.com> Date: Fri, 11 Apr 2014 09:31:54 +0530 Message-ID: Subject: Re: [PATCH 10/27] ARM: dts: exynos3250: Add new exynos3250.dtsi file From: Sachin Kamat To: Chanwoo Choi Cc: Kukjin Kim , Tomasz Figa , linux-samsung-soc , Kyungmin Park , Inki Dae , Seung-Woo Kim , hyunhee.kim@samsung.com, yj44.cho@samsung.com, LKML , linux-arm-kernel Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chanwoo, On 10 April 2014 15:36, Chanwoo Choi wrote: > From: Tomasz Figa > > This patch add new exynos3250.dtsi to support Exynos3250 SoC and includes > chipid/sys_reg dt node. > > Signed-off-by: Tomasz Figa > Signed-off-by: Chanwoo Choi > Signed-off-by: Kyungmin Park > --- > arch/arm/boot/dts/exynos3250.dtsi | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 arch/arm/boot/dts/exynos3250.dtsi > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > new file mode 100644 > index 0000000..3c8cee6 > --- /dev/null > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -0,0 +1,34 @@ > +/* > + * Samsung's Exynos3250 SoC device tree source > + * > + * Copyright (c) 2014 Samsung Electronics Co., Ltd. > + * http://www.samsung.com > + * > + * Samsung's Exynos3250 SoC device nodes are listed in this file. Exynos3250 > + * based board files can include this file and provide values for board specfic > + * bindings. > + * > + * Note: This file does not include device nodes for all the controllers in > + * Exynos3250 SoC. As device tree coverage for Exynos3250 increases, additional > + * nodes can be added to this file. > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + */ > + > +#include "skeleton.dtsi" > + > +/ { > + compatible = "samsung,exynos3250"; > + > + chipid@10000000 { > + compatible = "samsung,exynos4210-chipid"; > + reg = <0x10000000 0x100>; > + }; > + > + sys_reg: syscon@10010000 { > + compatible = "samsung,exynos3-sysreg", "syscon"; > + reg = <0x10010000 0x400>; > + }; > +}; Shouldn't these be grouped under the soc node? -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/