Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754534AbaDKRv6 (ORCPT ); Fri, 11 Apr 2014 13:51:58 -0400 Received: from mail1.bemta7.messagelabs.com ([216.82.254.108]:38100 "EHLO mail1.bemta7.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863AbaDKRv5 (ORCPT ); Fri, 11 Apr 2014 13:51:57 -0400 X-Env-Sender: Benjamin.Romer@unisys.com X-Msg-Ref: server-14.tower-200.messagelabs.com!1397238714!16095417!1 X-Originating-IP: [192.61.61.105] X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked From: "Romer, Benjamin M" To: "H. Peter Anvin" CC: Jet Chen , Fengguang Wu , Paolo Bonzini , Borislav Petkov , LKML Date: Fri, 11 Apr 2014 12:51:53 -0500 Subject: Re: [visorchipset] invalid opcode: 0000 [#1] PREEMPT SMP Thread-Topic: [visorchipset] invalid opcode: 0000 [#1] PREEMPT SMP Thread-Index: Ac9VrrkIEAXHC4aeR0qj17TZunP1Vg== Message-ID: References: <20140407111725.GC25152@localhost> <53444220.50009@intel.com> <53458A3A.1050608@intel.com> <20140409230114.GB8370@localhost> <5345D360.5000506@linux.intel.com> <53475344.5090009@linux.intel.com> <53481976.3020209@zytor.com> <534827F5.1020004@intel.com> <5348291B.7090501@zytor.com> In-Reply-To: <5348291B.7090501@zytor.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id s3BHq6hf006213 On Fri, 2014-04-11 at 10:40 -0700, H. Peter Anvin wrote: > On 04/11/2014 10:35 AM, Jet Chen wrote: > > > > As Peter said, QEMU probably should *not* set the hypervisor bit. But based on my testing, I think KVM works properly in this case. > > > > Either way, unless there is a CPUID interface exposed in CPUID levels > 0x40000000+, then relying on the hypervisor bit to do VMCALL is wrong in > the extreme. > > -hpa > > I'll pass your feedback on to the people who wrote the bad code. Sorry for the trouble. :) -- Ben ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?