Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754750AbaDKVXr (ORCPT ); Fri, 11 Apr 2014 17:23:47 -0400 Received: from g5t1625.atlanta.hp.com ([15.192.137.8]:17143 "EHLO g5t1625.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754300AbaDKVXp (ORCPT ); Fri, 11 Apr 2014 17:23:45 -0400 Message-ID: <1397251420.2503.25.camel@buesod1.americas.hpqcorp.net> Subject: Re: [PATCH] [v2] mm: pass VM_BUG_ON() reason to dump_page() From: Davidlohr Bueso To: Dave Hansen Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, dave.hansen@linux.intel.com, kirill.shutemov@linux.intel.com Date: Fri, 11 Apr 2014 14:23:40 -0700 In-Reply-To: <20140411204232.C8CF1A7A@viggo.jf.intel.com> References: <20140411204232.C8CF1A7A@viggo.jf.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.4 (3.6.4-3.fc18) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2014-04-11 at 13:42 -0700, Dave Hansen wrote: > Changes from v1: > * Fix tabs before spaces in the multi-line #define > > -- > From: Dave Hansen > > I recently added a patch to let folks pass a "reason" string > dump_page() which gets dumped out along with the page's data. > This essentially saves the bug-reader a trip in to the source > to figure out why we BUG_ON()'d. > > The new VM_BUG_ON_PAGE() passes in NULL for "reason". It seems > like we might as well pass the BUG_ON() condition if we have it. > This will bloat kernels a bit with ~160 new strings, but this > is all under a debugging option anyway. > > page:ffffea0008560280 count:1 mapcount:0 mapping:(null) index:0x0 > page flags: 0xbfffc0000000001(locked) > page dumped because: VM_BUG_ON_PAGE(PageLocked(page)) > ------------[ cut here ]------------ > kernel BUG at /home/davehans/linux.git/mm/filemap.c:464! > invalid opcode: 0000 [#1] SMP > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.14.0+ #251 > Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011 > ... > > > Signed-off-by: Dave Hansen > Acked-by: Kirill A. Shutemov Acked-by: Davidlohr Bueso -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/