Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755872AbaDKWzA (ORCPT ); Fri, 11 Apr 2014 18:55:00 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:42077 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755110AbaDKWy7 (ORCPT ); Fri, 11 Apr 2014 18:54:59 -0400 MIME-Version: 1.0 In-Reply-To: <1371555182-12418-2-git-send-email-mathias.nyman@linux.intel.com> References: <1371555182-12418-1-git-send-email-mathias.nyman@linux.intel.com> <1371555182-12418-2-git-send-email-mathias.nyman@linux.intel.com> Date: Fri, 11 Apr 2014 17:54:56 -0500 Message-ID: Subject: Re: [PATCH v3 1/1] pinctrl: add Intel BayTrail GPIO/pinctrl support From: Timur Tabi To: Mathias Nyman Cc: Linus , Grant Likely , lkml Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 18, 2013 at 6:33 AM, Mathias Nyman wrote: > > Pins may be muxed to alternate function instead of gpio by firmware. > This driver does not touch the pin muxing and expect firmare > to set pin muxing and pullup/down properties properly. > > Signed-off-by: Mathias Nyman > --- > drivers/pinctrl/Kconfig | 12 + > drivers/pinctrl/Makefile | 1 + > drivers/pinctrl/pinctrl-baytrail.c | 543 ++++++++++++++++++++++++++++++++++++ I know it's been ten months since you posted this driver, but I have a question. If this driver does not touch the pin muxing, and it doesn't even call pinctrl_register(), then why is it in drivers/pinctrl? It's not a pinctrl driver. Why isn't this a regular GPIO drivers in drivers/gpio? -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/