Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755553AbaDLR0v (ORCPT ); Sat, 12 Apr 2014 13:26:51 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:44422 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752800AbaDLR0t (ORCPT ); Sat, 12 Apr 2014 13:26:49 -0400 Message-ID: <534977A7.3090100@kernel.org> Date: Sat, 12 Apr 2014 18:28:07 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Joel Porquet , gregkh@linuxfoundation.org, jg1.han@samsung.com CC: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: iio: fix coding style References: <1397066985-2504-1-git-send-email-joel@porquet.org> In-Reply-To: <1397066985-2504-1-git-send-email-joel@porquet.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/04/14 19:09, Joel Porquet wrote: > As suggested by checkpatch.pl, use dev_info() instead of > printk(KERN_INFO ...) to print message. > > Signed-off-by: Joel Porquet > --- > Only tested by compilation. > drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c > index 48a6afa..38ecb4b 100644 > --- a/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c > +++ b/drivers/staging/iio/trigger/iio-trig-periodic-rtc.c > @@ -33,7 +33,8 @@ static int iio_trig_periodic_rtc_set_state(struct iio_trigger *trig, bool state) > struct iio_prtc_trigger_info *trig_info = iio_trigger_get_drvdata(trig); > if (trig_info->frequency == 0) > return -EINVAL; > - printk(KERN_INFO "trigger frequency is %d\n", trig_info->frequency); > + dev_info(&trig_info->rtc->dev, "trigger frequency is %d\n", > + trig_info->frequency); The principle is good, but why make the error message us the underlying rtc device? Going to lead to a rather unhelpful error message. Perhaps the iio_trigger structures device element would make more sense? Might not be terribly informative, but will at least come from the right subsystem. Also, I think we will be dropping this driver entirely at some point. It was a dodgy hack that perhaps made sense at the time, but now a high resolution timer is going to give better results. > return rtc_irq_set_state(trig_info->rtc, &trig_info->task, state); > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/