Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750859AbaDMVgd (ORCPT ); Sun, 13 Apr 2014 17:36:33 -0400 Received: from cpsmtpb-ews02.kpnxchange.com ([213.75.39.5]:51332 "EHLO cpsmtpb-ews02.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750763AbaDMVgc (ORCPT ); Sun, 13 Apr 2014 17:36:32 -0400 Message-ID: <1397424990.31896.10.camel@x220> Subject: Re: [PATCH v2 2/3] Fix coding style problem (cast with space) in drivers/staging/crystalhd/crystalhd_lnx.c From: Paul Bolle To: Pascal COMBES Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, Peter P Waskiewicz Jr , Jarod Wilson , Jingoo Han , Valentina Manea , linux-kernel@vger.kernel.org, Naren Sankar , Monam Agarwal , Scott Davilla , Amarjargal Gundjalam , Dan Carpenter , Robert Foss Date: Sun, 13 Apr 2014 23:36:30 +0200 In-Reply-To: <534AE1D6.1040304@orange.fr> References: <534AAED2.7050205@orange.fr> <20140413154859.GA18189@kroah.com> <534AE1D6.1040304@orange.fr> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-2.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 13 Apr 2014 21:36:31.0285 (UTC) FILETIME=[6F4D5650:01CF5760] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2014-04-13 at 21:13 +0200, Pascal COMBES wrote: > From: Pascal COMBES > > Fix coding style problem in drivers/staging/crystalhd/crystalhd_lnx.c: > No space needed before a cast. > > Signed-off-by: Pascal COMBES > --- > diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c > index fd7f08a..15e8f02 100644 > --- a/drivers/staging/crystalhd/crystalhd_lnx.c > +++ b/drivers/staging/crystalhd/crystalhd_lnx.c > @@ -28,7 +28,7 @@ static struct crystalhd_adp *g_adp_info; > > static irqreturn_t chd_dec_isr(int irq, void *arg) > { > - struct crystalhd_adp *adp = (struct crystalhd_adp *) arg; > + struct crystalhd_adp *adp = (struct crystalhd_adp *)arg; Shouldn't this cast just be dropped instead? > int rc = 0; > if (adp) > rc = crystalhd_cmd_interrupt(&adp->cmds); > Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/