Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753554AbaDNCUA (ORCPT ); Sun, 13 Apr 2014 22:20:00 -0400 Received: from mail-ie0-f172.google.com ([209.85.223.172]:63499 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbaDNCT4 (ORCPT ); Sun, 13 Apr 2014 22:19:56 -0400 MIME-Version: 1.0 In-Reply-To: <31741678.fEkJSmnf5n@daeseok-laptop.cloud.net> References: <31741678.fEkJSmnf5n@daeseok-laptop.cloud.net> Date: Mon, 14 Apr 2014 11:19:56 +0900 Message-ID: Subject: Re: [PATCH 2/2] nfc: remove unneeded nfc_put_device() calls From: DaeSeok Youn To: David Miller , lauro.venancio@openbossa.org Cc: aloisio.almeida@openbossa.org, sameo@linux.intel.com, linux-wireless@vger.kernel.org, linux-nfc@ml01.01.org, netdev@vger.kernel.org, linux-kernel Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Can you review this patch? Thanks. Daeseok Youn 2014-04-02 16:56 GMT+09:00 Daeseok Youn : > > If local is NULL, nfs_put_device() is called twice. > So nfs_put_device() in "if (!local)" is removed. > > Signed-off-by: Daeseok Youn > --- > net/nfc/netlink.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c > index b2ad570..3e0a676 100644 > --- a/net/nfc/netlink.c > +++ b/net/nfc/netlink.c > @@ -1038,7 +1038,6 @@ static int nfc_genl_llc_sdreq(struct sk_buff *skb, struct genl_info *info) > > local = nfc_llcp_find_local(dev); > if (!local) { > - nfc_put_device(dev); > rc = -ENODEV; > goto exit; > } > -- > 1.7.4.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/