Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751198AbaDNDDw (ORCPT ); Sun, 13 Apr 2014 23:03:52 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:57345 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbaDNDDu (ORCPT ); Sun, 13 Apr 2014 23:03:50 -0400 MIME-Version: 1.0 In-Reply-To: <1397443846.5243.2.camel@joe-AO722> References: <1397443846.5243.2.camel@joe-AO722> From: Pranith Kumar Date: Sun, 13 Apr 2014 23:03:19 -0400 Message-ID: Subject: Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern definition To: Joe Perches Cc: LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 13, 2014 at 10:50 PM, Joe Perches wrote: >> >> -/* >> - * This function really isn't for public consumption, but RCU is special in >> - * that context switches can allow the state machine to make progress. >> - */ >> -extern void resched_cpu(int cpu); > > why not #include "sched.h" > > and remove both declarations? > > As the comment mentions, resched_cpu is internal to the scheduler and hence is in sched/sched.h file and not in linux/sched.h. sched/sched.h cannot be included in other subsystems directly. Regards, -- Pranith -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/