Message-ID: <1397445480.5243.6.camel@joe-AO722>
Subject: Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern
 definition
From: Joe Perches <joe@perches.com>
To: Pranith Kumar <bobby.prani@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Date: Sun, 13 Apr 2014 20:18:00 -0700
In-Reply-To: <CAJhHMCBsa6ypbaLZ2Uv6x60uU-xq=veAem85Ke=-R+nbW5=5fA@mail.gmail.com>
References: <CAJhHMCCE0QHvzqrdY-w8bB8ZK=JRN02V29XwaFYRXmu=9RhG9Q@mail.gmail.com>
	 <CAJhHMCCgMgL2etE8sYPgUfy+OXcyxG6_X1v1OhUxzX5c0kaZ4w@mail.gmail.com>
	 <1397443846.5243.2.camel@joe-AO722>
	 <CAJhHMCBsa6ypbaLZ2Uv6x60uU-xq=veAem85Ke=-R+nbW5=5fA@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Sun, 2014-04-13 at 23:03 -0400, Pranith Kumar wrote:
> On Sun, Apr 13, 2014 at 10:50 PM, Joe Perches <joe@perches.com> wrote:
> >> -/*
> >> - * This function really isn't for public consumption, but RCU is special in
> >> - * that context switches can allow the state machine to make progress.
> >> - */
> >> -extern void resched_cpu(int cpu);
> >
> > why not #include "sched.h"
> > and remove both declarations?
> As the comment mentions, resched_cpu is internal to the scheduler and
> hence is in sched/sched.h file and not in linux/sched.h.

Note the use of quotes and lack of angle brackets.

> sched/sched.h cannot be included in other subsystems directly.

If functions from it can be declared extern,
then likely it could be used in an #include.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/