Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752263AbaDNDca (ORCPT ); Sun, 13 Apr 2014 23:32:30 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:47503 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826AbaDNDc3 (ORCPT ); Sun, 13 Apr 2014 23:32:29 -0400 MIME-Version: 1.0 In-Reply-To: <1397445480.5243.6.camel@joe-AO722> References: <1397443846.5243.2.camel@joe-AO722> <1397445480.5243.6.camel@joe-AO722> From: Pranith Kumar Date: Sun, 13 Apr 2014 23:31:57 -0400 Message-ID: Subject: Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern definition To: Joe Perches Cc: LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 13, 2014 at 11:18 PM, Joe Perches wrote: >> As the comment mentions, resched_cpu is internal to the scheduler and >> hence is in sched/sched.h file and not in linux/sched.h. > > Note the use of quotes and lack of angle brackets. > >> sched/sched.h cannot be included in other subsystems directly. > > If functions from it can be declared extern, > then likely it could be used in an #include. > > All the users of resched_cpu are in kernel/sched/ and in kernel/rcu/tree.c. I think the only reason this was declared extern was for the special use in rcu/tree.c. -- Pranith -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/