Date: Mon, 14 Apr 2014 12:03:35 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
        hpa@zytor.com, x86@kernel.org, bp@suse.de,
        paul.gortmaker@windriver.com, JBeulich@suse.com, prarit@redhat.com,
        drjones@redhat.com, toshi.kani@hp.com, riel@redhat.com,
        gong.chen@linux.intel.com, andi@firstfloor.org, lenb@kernel.org,
        rjw@rjwysocki.net, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v3 1/5] x86: initialize secondary CPU only if master CPU
 will wait for it
Message-ID: <20140414100335.GC731@gmail.com>
References: <1397150061-29735-1-git-send-email-imammedo@redhat.com>
 <1397150061-29735-2-git-send-email-imammedo@redhat.com>
 <20140414091600.GA19771@gmail.com>
 <20140414115210.51193098@thinkpad>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140414115210.51193098@thinkpad>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org


* Igor Mammedov <imammedo@redhat.com> wrote:

> On Mon, 14 Apr 2014 11:16:00 +0200
> Ingo Molnar <mingo@kernel.org> wrote:
> 
> > 
> > * Igor Mammedov <imammedo@redhat.com> wrote:
> > 
> > >  	/*
> > > +	 * wait for ACK from master CPU before continuing
> > > +	 * with AP initialization
> > > +	 */
> > > +	cpumask_set_cpu(cpu, cpu_initialized_mask);
> > > +	while (!cpumask_test_cpu(cpu, cpu_callout_mask))
> > > +		cpu_relax();
> > 
> > > +	/*
> > > +	 * wait for ACK from master CPU before continuing
> > > +	 * with AP initialization
> > > +	 */
> > > +	cpumask_set_cpu(cpu, cpu_initialized_mask);
> > > +	while (!cpumask_test_cpu(cpu, cpu_callout_mask))
> > > +		cpu_relax();
> > 
> > That repetitive pattern could be stuck into a properly named helper 
> > inline function.
> sure
> 
> > (Also, before the cpumask_set_cpu() we should probably do a WARN_ON() 
> > if the bit is already set.)
> The reason why there is no any WARN_ON or likes is that printk is quite
> complicated, takes looks and so on. [...]

[ Yeah, I too heard that printk(), like a pretty girl, is complicated
  and makes people look twice. ]

> [...] So it's not safe at this point since
> CPU could be shot down by any time by INIT/SIPI until it's out of 
> cpu_callout_mask loop.

Not sure where you got that from, but it's not a valid concern really: 
the only place where we don't want to do a printk() is in printk code 
itself.

Debug warnings, by definition, should never trigger. If they trigger 
then they will very likely not cause lockups, but will cause the bug 
to be fixed.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/