Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753486AbaDNMaU (ORCPT ); Mon, 14 Apr 2014 08:30:20 -0400 Received: from cantor2.suse.de ([195.135.220.15]:59816 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751128AbaDNMaS (ORCPT ); Mon, 14 Apr 2014 08:30:18 -0400 Date: Mon, 14 Apr 2014 14:30:17 +0200 Message-ID: From: Takashi Iwai To: Clemens Ladisch Cc: "Li, Zhen-Hua" , Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] driver/snd: es18xx driver should use udelay error In-Reply-To: <534BCDE8.1090202@ladisch.de> References: <1397468588-18559-1-git-send-email-zhen-hual@hp.com> <534BCDE8.1090202@ladisch.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 14 Apr 2014 14:00:40 +0200, Clemens Ladisch wrote: > > Li, Zhen-Hua wrote: > > udelay with more than 20000 may cause __bad_udelay. > > Use mdelay for instead. > > > > #ifdef AVOID_POPS > > /* Avoid pops */ > > - udelay(100000); > > + mudelay(100); > > This will not compile. Please test with AVOID_POPS enabled. Oops, thanks for spotting. I fixed it now. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/