Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755233AbaDNN7p (ORCPT ); Mon, 14 Apr 2014 09:59:45 -0400 Received: from qmta01.emeryville.ca.mail.comcast.net ([76.96.30.16]:43152 "EHLO qmta01.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbaDNN7o (ORCPT ); Mon, 14 Apr 2014 09:59:44 -0400 Date: Mon, 14 Apr 2014 08:59:39 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@nuc To: Johannes Hirte cc: Josh Cartwright , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Pekka Enberg , Matt Mackall , linux-mm@kvack.org Subject: Re: [PATCH -next] slub: Replace __this_cpu_inc usage w/ SLUB_STATS In-Reply-To: <20140414153424.0eca4c7d@datenkhaos.de> Message-ID: References: <20140306194821.3715d0b6212cc10415374a68@canb.auug.org.au> <20140306155316.GG18529@joshc.qualcomm.com> <20140306182941.GH18529@joshc.qualcomm.com> <20140414153424.0eca4c7d@datenkhaos.de> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Apr 2014, Johannes Hirte wrote: > kernel/watchdog.c: > > void touch_softlockup_watchdog(void) > { > __this_cpu_write(watchdog_touch_ts, 0); > } > EXPORT_SYMBOL(touch_softlockup_watchdog); > > Don't know if the change to this_cpu_write() is the right way here too. Well yes lets change that to this_cpu_write(). I doubt there are significant performance issues here. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/