Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755953AbaDNQ3p (ORCPT ); Mon, 14 Apr 2014 12:29:45 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:62962 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755016AbaDNQ2T convert rfc822-to-8bit (ORCPT ); Mon, 14 Apr 2014 12:28:19 -0400 MIME-Version: 1.0 In-Reply-To: References: <20140414160743.GF4496@linux.vnet.ibm.com> From: Pranith Kumar Date: Mon, 14 Apr 2014 12:27:47 -0400 X-Google-Sender-Auth: qFXFH8JKjsJuLMB-sOQx1O2DitA Message-ID: Subject: Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern definition To: Paul McKenney Cc: LKML Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 14, 2014 at 12:19 PM, Pranith Kumar wrote: > Hi Paul, > > On Mon, Apr 14, 2014 at 12:07 PM, Paul E. McKenney > wrote: >> On Sun, Apr 13, 2014 at 05:53:53PM -0400, Pranith Kumar wrote: >>> remove duplicate definition of extern resched_cpu >>> >>> Signed-off-by: Pranith Kumar >> >> Hello, Pranith, >> >> When I apply this patch I get the following: >> >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c: In function ‘rcu_implicit_dynticks_qs’: >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:895:3: error: implicit declaration of function ‘resched_cpu’ [-Werror=implicit-function-declaration] >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c: At top level: >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:1009:13: warning: conflicting types for ‘resched_cpu’ [enabled by default] >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:895:3: note: previous implicit declaration of ‘resched_cpu’ was here >> >> This failed in under number of different Kconfig setups, the .config file >> for one of them is attached. >> >> So this declaration really is needed. Just out of curiosity, what led >> you to believe that it could be removed? >> Your attached config has the following: Linux/x86 3.14.0-rc3 Kernel Configuration The patch is against 3.15.0-rc1 (the latest at this time). May be that is the reason? -- Pranith -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/