From: Jingoo Han <jg1.han@samsung.com>
To: "'Christian Engelmayer'" <cengelma@gmx.at>,
        "'Brian Norris'" <computersforpeace@gmail.com>
Cc: "'David Woodhouse'" <dwmw2@infradead.org>, "'Pekon Gupta'" <pekon@ti.com>,
        "'Artem Bityutskiy'" <artem.bityutskiy@linux.intel.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        "'Jingoo Han'" <jg1.han@samsung.com>
References: <20140415003205.0bb2cf44@spike>
In-reply-to: <20140415003205.0bb2cf44@spike>
Subject: =?utf-8?Q?Re:_=5BPATCH=5D_mtd:_nand:_omap:_fix?=
	=?utf-8?Q?_compile_warning_on_=E2=80=98erased=5Fsect?=
	=?utf-8?Q?or=5Fbitflips=E2=80=99?=
Date: Tue, 15 Apr 2014 09:33:03 +0900
Message-id: <007d01cf5842$435dcba0$ca1962e0$%han@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 8BIT
Thread-index: Ac9YMWblLG2q3V2ESE+KWJVfGHIuJAAELwlw
Content-language: ko
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org

On Tuesday, April 15, 2014 7:32 AM, Christian Engelmayer wrote:
> 
> Commit 2c9f2365 (mtd: nand: omap: ecc.calculate: merge omap3_calculate_ecc_bch4
> in omap_calculate_ecc_bch) introduced minor compile warning
> "‘erased_sector_bitflips’ defined but not used [-Wunused-function]" when
> compiling without CONFIG_MTD_NAND_OMAP_BCH. Move function
> erased_sector_bitflips() into the same ifdef section as the only caller.
> 
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>

Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> ---
>  drivers/mtd/nand/omap2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 1ff49b8..1b800bc 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1237,6 +1237,7 @@ static int __maybe_unused omap_calculate_ecc_bch(struct mtd_info *mtd,
>  	return 0;
>  }
> 
> +#ifdef CONFIG_MTD_NAND_OMAP_BCH
>  /**
>   * erased_sector_bitflips - count bit flips
>   * @data:	data sector buffer
> @@ -1276,7 +1277,6 @@ static int erased_sector_bitflips(u_char *data, u_char *oob,
>  	return flip_bits;
>  }
> 
> -#ifdef CONFIG_MTD_NAND_OMAP_BCH
>  /**
>   * omap_elm_correct_data - corrects page data area in case error reported
>   * @mtd:	MTD device structure
> --
> 1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/