From: Jingoo Han <jg1.han@samsung.com>
To: "'Pascal COMBES'" <pascom@orange.fr>, "'Paul Bolle'" <pebolle@tiscali.nl>
Cc: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
        devel@driverdev.osuosl.org,
        "'Peter P Waskiewicz Jr'" <peter.p.waskiewicz.jr@intel.com>,
        "'Jarod Wilson'" <jarod@wilsonet.com>,
        "'Valentina Manea'" <valentina.manea.m@gmail.com>,
        linux-kernel@vger.kernel.org, "'Naren Sankar'" <nsankar@broadcom.com>,
        "'Monam Agarwal'" <monamagarwal123@gmail.com>,
        "'Scott Davilla'" <davilla@4pi.com>,
        "'Amarjargal Gundjalam'" <amarjargal16@gmail.com>,
        "'Dan Carpenter'" <dan.carpenter@oracle.com>,
        "'Robert Foss'" <dev@robertfoss.se>,
        "'Jingoo Han'" <jg1.han@samsung.com>
References: <534AAED2.7050205@orange.fr> <20140413154859.GA18189@kroah.com>
 <534AE1D6.1040304@orange.fr> <1397424990.31896.10.camel@x220>
 <534C0EE3.6080308@orange.fr>
In-reply-to: <534C0EE3.6080308@orange.fr>
Subject: Re: [PATCH v2 2/3] Fix coding style problem (cast with space) in
 drivers/staging/crystalhd/crystalhd_lnx.c
Date: Tue, 15 Apr 2014 09:44:17 +0900
Message-id: <008401cf5843$d4ce80b0$7e6b8210$%han@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1
Content-transfer-encoding: 8BIT
Thread-index: Ac9X/+i87oRtc3U0T4uK0o1AXJTVVQAQ44Gg
Content-language: ko
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org

On Tuesday, April 15, 2014 1:38 AM, Pascal COMBES wrote:
> 
> Le 13/04/2014 23:36, Paul Bolle a ?crit :
> > On Sun, 2014-04-13 at 21:13 +0200, Pascal COMBES wrote:
> >> From: Pascal COMBES <pascom@orange.fr>
> >>
> >> Fix coding style problem in drivers/staging/crystalhd/crystalhd_lnx.c:
> >> No space needed before a cast.
> >>
> >> Signed-off-by: Pascal COMBES <pascom@orange.fr>
> >> ---
> >> diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c
> >> index fd7f08a..15e8f02 100644
> >> --- a/drivers/staging/crystalhd/crystalhd_lnx.c
> >> +++ b/drivers/staging/crystalhd/crystalhd_lnx.c
> >> @@ -28,7 +28,7 @@ static struct crystalhd_adp *g_adp_info;
> >>
> >>  static irqreturn_t chd_dec_isr(int irq, void *arg)
> >>  {
> >> -	struct crystalhd_adp *adp = (struct crystalhd_adp *) arg;
> >> +	struct crystalhd_adp *adp = (struct crystalhd_adp *)arg;
> >
> > Shouldn't this cast just be dropped instead?
> 
> I think as you and was wondering why it was there but I didn't dare
> removing it. I considered it was not really coding style.
> But after second thought, I will remove it when I resend tomrorrow.

Please, remove unnecessary void cast as below.

 -	struct crystalhd_adp *adp = (struct crystalhd_adp *) arg;
 +	struct crystalhd_adp *adp = arg;

This is because the conversion from void pointer to any other
pointer type is guaranteed by the C programming language.
So, void cast is unnecessary.

Best regards,
Jingoo Han

> 	Regards,
> Pascal COMBES.
> >
> >>  	int rc = 0;
> >>  	if (adp)
> >>  		rc = crystalhd_cmd_interrupt(&adp->cmds);
> >>
> >
> >
> > Paul Bolle
> >
> >

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/