Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751786AbaDOFcq (ORCPT ); Tue, 15 Apr 2014 01:32:46 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:39643 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbaDOFco (ORCPT ); Tue, 15 Apr 2014 01:32:44 -0400 MIME-Version: 1.0 In-Reply-To: <534C4E36.9060208@semaphore.gr> References: <534C4E36.9060208@semaphore.gr> Date: Tue, 15 Apr 2014 11:02:43 +0530 Message-ID: Subject: Re: [PATCH 02/20] cpufreq: acpi-cpufreq: Use cpufreq_for_each_entry macro for iteration From: Viresh Kumar To: Stratos Karafotis Cc: "Rafael J. Wysocki" , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15 April 2014 02:38, Stratos Karafotis wrote: > The cpufreq core supports the cpufreq_for_each_entry macro helper > for iteration over the cpufreq_frequency_table, so use it. > > It should have no functional changes. > > Signed-off-by: Stratos Karafotis > --- > drivers/cpufreq/acpi-cpufreq.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c > index 000e4e0..12a5750 100644 > --- a/drivers/cpufreq/acpi-cpufreq.c > +++ b/drivers/cpufreq/acpi-cpufreq.c > @@ -213,7 +213,7 @@ static unsigned extract_io(u32 value, struct acpi_cpufreq_data *data) > > static unsigned extract_msr(u32 msr, struct acpi_cpufreq_data *data) > { > - int i; > + struct cpufreq_frequency_table *pos; > struct acpi_processor_performance *perf; > > if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD) > @@ -223,11 +223,11 @@ static unsigned extract_msr(u32 msr, struct acpi_cpufreq_data *data) > > perf = data->acpi_data; > > - for (i = 0; data->freq_table[i].frequency != CPUFREQ_TABLE_END; i++) { > - if (msr == perf->states[data->freq_table[i].driver_data].status) > - return data->freq_table[i].frequency; > + cpufreq_for_each_entry(pos, data->freq_table) { > + if (msr == perf->states[pos->driver_data].status) > + return pos->frequency; > } > - return data->freq_table[0].frequency; > + return data->freq_table->frequency; This isn't a related change, isn't it? Also it make it less readable. So probably just leave it as is. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/