Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751558AbaDOGBx (ORCPT ); Tue, 15 Apr 2014 02:01:53 -0400 Received: from mail-oa0-f50.google.com ([209.85.219.50]:37729 "EHLO mail-oa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750930AbaDOGBu (ORCPT ); Tue, 15 Apr 2014 02:01:50 -0400 MIME-Version: 1.0 In-Reply-To: <534C4E14.3080509@semaphore.gr> References: <534C4E14.3080509@semaphore.gr> Date: Tue, 15 Apr 2014 11:31:49 +0530 Message-ID: Subject: Re: [PATCH 00/20] Introduce new cpufreq helper macros From: Viresh Kumar To: Stratos Karafotis Cc: "Rafael J. Wysocki" , "David S. Miller" , Hans-Christian Egtvedt , Dirk Brandewie , Randy Dunlap , linux-doc@vger.kernel.org, Linux Kernel Mailing List , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15 April 2014 02:37, Stratos Karafotis wrote: > This patch set introduces two freq_table helper macros which > can be used for iteration over cpufreq_frequency_table and > makes the necessary changes to cpufreq core and drivers that > use such an iteration procedure. > > The motivation was a usage of common procedure to iterate over > cpufreq_frequency_table across all drivers and cpufreq core. > > This was tested on a x86_64 platform. > Patches 4-17 compiled successfully but unfortunately I was not > able to compile test patches 18-20. Mostly okay, just some Nitpicks.. Please rearrange your patches this way: - First patch just adds the wrappers - Second one makes changes to drivers/cpufreq/, i.e. include all core and drivers changes into a single patch here as the logs are exactly same. - Then framework by framework, as we may need Acks/Reviews by them separately.. So, probably just 5-7 would do. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/